-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversion metrics #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie this generally looks to go from my end! I was able to test all the passthrough and default override cases and everything looks to be working as expected!
I have a few comments below, but nothing that would be blocking the approval. Once those updates are applied, this should be good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie All lgtm!
PR Overview
This PR will address the following Issue/Feature:
add conversions project
This PR will result in the following new package version:
v0.8.0
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Feature Updates: Native Conversion Support
We have added more robust support for conversions in our data models by doing the following:
twitter_ads__conversion_fields
andtwitter_ads__conversion_sale_amount_fields
variables to pass through conversion metrics (total number and monetary value, respectively).twitter_ads__conversion_fields
will includeconversion_purchases_metric
andconversion_custom_metric
.twitter_ads__conversion_sale_amount_fields
will includeconversion_purchases_sale_amount
andconversion_custom_sale_amount
.total_conversions
andtotal_conversions_sale_amount
columns.Under the Hood
persist_pass_through_columns()
macro in which we can include coalesces and properly check between conversion field values and the existing passthrough columns.integration_tests
for the Twitter Ads transformation models.Documentation
url_clicks
andspend_micro
were missing from this README section.twitter_ads__conversion_fields
andtwitter_ads__conversion_sale_amount_fields
variables here.Contributors
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
See validation tests added
If you had to summarize this PR in an emoji, which would it be?
🐦