-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add union data #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look great to me! I have a few small comments below, but otherwise this is good to generate the docs and be approved!
As discussed during standup, we will hold off merging and releasing this until all other union data updates are completed this quarter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie thanks for working through this PR! I do have a few comments and questions below that I would like for you to take a look at before approving. Let me know if you would like to discuss any of these in more detail. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this PR looks great! Just a few comments and suggestions below, but nothing I feel that should block this approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie Just a few suggestions but otherwise lgtm! Woohoo union data updates!
Co-authored-by: fivetran-catfritz <[email protected]>
PR Overview
This PR will address the following Issue/Feature:
fivetran/dbt_zendesk#124
This PR will result in the following new package version:
v0.14.0
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
for now, i have a very very brief entry that points to the README
dbt_zendesk_source v0.11.0
🎉 Feature Update 🎉
This release supports running the package on multiple Zendesk sources at once! See the README for details on how to leverage this feature (PR #44).
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
See hex notebook linked in Height