Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GROUP reserved keyword handling for new union_data use case #57

Closed
wants to merge 10 commits into from

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Dec 6, 2024

PR Overview

This PR will address the following Issue/Feature:
https://getdbt.slack.com/archives/C01D1R2JLLA/p1733513338340409

This PR will result in the following new package version:

0.14.1

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fixes

  • In v0.19.0, Snowflake users may have seen when searching for a relation, dbt found an approximate match errors when running the stg_zendesk__group_tmp model. We have updated the reserved keyword handling of the group source table and adjusted its quoting in order to eradicate this issue.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

If you had to summarize this PR in an emoji, which would it be?

🗝️

@fivetran-jamie fivetran-jamie self-assigned this Dec 6, 2024
@fivetran-jamie fivetran-jamie deleted the bugfix/group-reserved-kw-union-data branch December 9, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant