From 7318c22343382c88cdf38615807d7c6e7ef15138 Mon Sep 17 00:00:00 2001 From: Sourya Kovvali <12588291+souryavarenya@users.noreply.github.com> Date: Fri, 26 Jan 2024 12:28:35 +0100 Subject: [PATCH] Fix driver and docs --- fixposition_driver_ros1/README.md | 2 +- fixposition_driver_ros2/README.md | 3 ++- fixposition_driver_ros2/src/fixposition_driver_node.cpp | 1 - 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fixposition_driver_ros1/README.md b/fixposition_driver_ros1/README.md index 4039904..9ed24ae 100644 --- a/fixposition_driver_ros1/README.md +++ b/fixposition_driver_ros1/README.md @@ -45,7 +45,7 @@ make sure you have sourced the setup.bash from ros: `/opt/ros/{ROS_DISTRO}/setup.bash`, for example ``` -source /opt/ros/melodic/setup.bash` +source /opt/ros/melodic/setup.bash ``` and build it with: diff --git a/fixposition_driver_ros2/README.md b/fixposition_driver_ros2/README.md index cd0b2cf..c42d73d 100644 --- a/fixposition_driver_ros2/README.md +++ b/fixposition_driver_ros2/README.md @@ -21,6 +21,7 @@ This driver operates as a ROS node, connecting to either a TCP or serial stream sudo apt update sudo apt install -y build-essential cmake sudo apt install -y libeigen3-dev + sudo apt install -y libboost-date-time-dev ``` @@ -34,7 +35,7 @@ fp_public_ws ├── src │ ├── fixposition_driver │ │ ├── fixposition_driver_lib -│ │ ├── fixposition_driver_ros1 # will be ignore by colcon when building for ROS2 +│ │ ├── fixposition_driver_ros1 # will be ignored by colcon when building for ROS2 │ │ ├── fixposition_driver_ros2 │ ├── fixposition_gnss_tf ``` diff --git a/fixposition_driver_ros2/src/fixposition_driver_node.cpp b/fixposition_driver_ros2/src/fixposition_driver_node.cpp index 7c1d2b9..9cf849b 100644 --- a/fixposition_driver_ros2/src/fixposition_driver_node.cpp +++ b/fixposition_driver_ros2/src/fixposition_driver_node.cpp @@ -59,7 +59,6 @@ FixpositionDriverNode::FixpositionDriverNode(std::shared_ptr node, params_.customer_input.speed_topic, 100, std::bind(&FixpositionDriverNode::WsCallback, this, std::placeholders::_1)); - Connect(); RegisterObservers(); }