From 879de87c3d03f5a029ffd7f560687a544d9a67ff Mon Sep 17 00:00:00 2001 From: Julia Rechkunova Date: Tue, 6 Feb 2024 09:07:34 +0100 Subject: [PATCH] [Discover] Unskip edit data view test (#176134) - Closes https://github.com/elastic/kibana/issues/174066 ## Summary 50x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5022 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --- .../apps/management/data_views/_data_view_create_delete.ts | 3 +-- test/functional/page_objects/settings_page.ts | 3 +++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/test/functional/apps/management/data_views/_data_view_create_delete.ts b/test/functional/apps/management/data_views/_data_view_create_delete.ts index 4c8873f59b348..e3bc2240887ad 100644 --- a/test/functional/apps/management/data_views/_data_view_create_delete.ts +++ b/test/functional/apps/management/data_views/_data_view_create_delete.ts @@ -149,8 +149,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); }); - // FLAKY: https://github.com/elastic/kibana/issues/174066 - describe.skip('edit index pattern', () => { + describe('edit index pattern', () => { it('on edit click', async () => { await PageObjects.settings.editIndexPattern('logstash-*', '@timestamp', 'Logstash Star'); diff --git a/test/functional/page_objects/settings_page.ts b/test/functional/page_objects/settings_page.ts index 5e8fddb626efd..3208fb782e272 100644 --- a/test/functional/page_objects/settings_page.ts +++ b/test/functional/page_objects/settings_page.ts @@ -238,6 +238,9 @@ export class SettingsPageObject extends FtrService { async clickEditIndexButton() { await this.testSubjects.click('editIndexPatternButton'); + await this.retry.waitFor('flyout', async () => { + return await this.testSubjects.exists('indexPatternEditorFlyout'); + }); } async clickDeletePattern() {