-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Dockerfile more cache friendly #124
Comments
maringuu
added a commit
that referenced
this issue
Nov 7, 2023
Still not great as the whole installation happens after copying but at least not copying is not the first thing we do. Related #124
maringuu
added a commit
that referenced
this issue
Aug 15, 2024
Still not great as the whole installation happens after copying but at least not copying is not the first thing we do. Related #124
maringuu
added a commit
that referenced
this issue
Aug 15, 2024
Still not great as the whole installation happens after copying but at least copying is not the first thing we do anymore. Related #124
maringuu
added a commit
that referenced
this issue
Aug 15, 2024
Still not great as the whole installation happens after copying but at least copying is not the first thing we do anymore. Related #124
maringuu
added a commit
that referenced
this issue
Aug 15, 2024
Still not great as the whole installation happens after copying but at least not copying is not the first thing we do. Related #124
maringuu
added a commit
that referenced
this issue
Aug 22, 2024
Still not great as the whole installation happens after copying but at least copying is not the first thing we do anymore. Related #124
jstucke
pushed a commit
that referenced
this issue
Aug 23, 2024
Still not great as the whole installation happens after copying but at least copying is not the first thing we do anymore. Related #124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the first thing we do is copy the whole directory in the docker image.
So when changing anything the whole thing is rebuild from scratch.
A use case would be working on an unpacker. I don't want to wait 10 minutes just to text if it works.
There are two solutions I'd propose.
Making the image more mount firendly
A workaround would be to mount the fact_extractor directory in the container when developing.
This does not work for the following reasons.
Bin dir
Binaries are installed in the repo. Easy to change. I'd suggest
/usr/local/bin
.venv
The venv is installed in the repo. Easy to change. I'd siggest
/venv
for the docker image.Uncoupeling the installer
The installer is tightly coupled to the rest of the code.
If we could execute it separately then we could execute the installer first (which takes most of the time)
and then copy the rest of the directory.
Of course if you change sth in the plugin installers the image would not work which is not ideal.
The text was updated successfully, but these errors were encountered: