Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ethtool plugin #963

Merged
merged 1 commit into from
Jun 13, 2024
Merged

feat: add ethtool plugin #963

merged 1 commit into from
Jun 13, 2024

Conversation

ForFoen
Copy link
Contributor

@ForFoen ForFoen commented Jun 10, 2024

添加ethtool插件

go.sum Outdated Show resolved Hide resolved
@kongfei605
Copy link
Collaborator

kongfei605 commented Jun 11, 2024

可以参考一下其他插件多系统编译方式,https://github.com/flashcatcloud/categraf/tree/main/inputs/netstat
不然windows编译报错了 https://github.com/flashcatcloud/categraf/actions/runs/9463136799/job/26069883365 , make build-test会执行多平台编译测试,修改好之后可以本地跑一下哈

@ForFoen ForFoen force-pushed the ethtool branch 2 times, most recently from cafdbad to b707cb2 Compare June 11, 2024 13:26
@ForFoen
Copy link
Contributor Author

ForFoen commented Jun 12, 2024

您好,我想请教一下,在自己fork的仓库手动跑workflow,为什么报错的位置不一样
image
貌似运行的参数是有所不同的,即使用main分支来跑也会报该错误

@kongfei605
Copy link
Collaborator

您好,我想请教一下,在自己fork的仓库手动跑workflow,为什么报错的位置不一样 image 貌似运行的参数是有所不同的,即使用main分支来跑也会报该错误

这个要看你的workflow配置了 ,直接fork过去一般是跑不了的,因为里面配置的账号是flashcatcloud

@ForFoen
Copy link
Contributor Author

ForFoen commented Jun 12, 2024

好的,感谢回答

@kongfei605 kongfei605 merged commit 16c4a22 into flashcatcloud:main Jun 13, 2024
3 checks passed
@ForFoen ForFoen deleted the ethtool branch June 13, 2024 02:07
@ForFoen ForFoen restored the ethtool branch June 13, 2024 02:18
@ForFoen ForFoen deleted the ethtool branch June 13, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants