phpstan OK

flashteamdev · May 28, 2024 · a837972 · a837972
1 parent fce53f3
commit a837972
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 27 deletions.
diff --git a/.github/workflows/laravel.yml b/.github/workflows/laravel.yml
@@ -2,34 +2,37 @@ name: Laravel
 
 on:
   push:
-    branches: [ "main" ]
+    branches: ["main"]
   pull_request:
-    branches: [ "main" ]
+    branches: ["main"]
 
 jobs:
   laravel-tests:
-
     runs-on: ubuntu-latest
 
     steps:
-    - uses: shivammathur/setup-php@15c43e89cdef867065b0213be354c2841860869e
-      with:
-        php-version: '8.2'
-    - uses: actions/checkout@v4
-    - name: Copy .env
-      run: php -r "file_exists('.env') || copy('.env.example', '.env');"
-    - name: Install Dependencies
-      run: composer install -q --no-ansi --no-interaction --no-scripts --no-progress --prefer-dist
-    - name: Generate key
-      run: php artisan key:generate
-    - name: Directory Permissions
-      run: chmod -R 777 storage bootstrap/cache
-    - name: Create Database
-      run: |
-        mkdir -p database
-        touch database/database.sqlite
-    - name: Execute tests (Unit and Feature tests) via PHPUnit/Pest
-      env:
-        DB_CONNECTION: sqlite
-        DB_DATABASE: database/database.sqlite
-      run: php artisan test
+      - uses: shivammathur/setup-php@15c43e89cdef867065b0213be354c2841860869e
+        with:
+          php-version: "8.2"
+      - uses: actions/checkout@v4
+      - name: Copy .env
+        run: php -r "file_exists('.env') || copy('.env.example', '.env');"
+      - name: Install Dependencies
+        run: composer install -q --no-ansi --no-interaction --no-scripts --no-progress --prefer-dist
+      - name: Generate key
+        run: php artisan key:generate
+      - name: Directory Permissions
+        run: chmod -R 777 storage bootstrap/cache
+      - name: Create Database
+        run: |
+          mkdir -p database
+          touch database/database.sqlite
+      - name: phpstan analyse
+        run: ./vendor/bin/phpstan analyse
+      - name: pint format
+        run: ./vendor/bin/pint
+      - name: Execute tests (Unit and Feature tests) via PHPUnit/Pest
+        env:
+          DB_CONNECTION: sqlite
+          DB_DATABASE: database/database.sqlite
+        run: php artisan test
diff --git a/app/helpers.php b/app/helpers.php
@@ -28,7 +28,6 @@ function authUser(): User
 if (! function_exists('diskPublic')) {
     function diskPublic(): FilesystemAdapter
     {
-        // @phpstan-ignore-next-line
         return Storage::disk('public');
     }
 }
@@ -51,7 +50,7 @@ function typeString(mixed $value, string $fallback = ''): string
 
 if (! function_exists('typeArray')) {
     /**
-     * @param  array<mixed>  $default
+     * @param  array<mixed>  $fallback
      * @return array<mixed>
      *
      * @throws BindingResolutionException

diff --git a/phpstan.neon b/phpstan.neon
@@ -10,7 +10,7 @@ parameters:
     level: 9
 
     ignoreErrors:
-        - '#Unsafe usage of new static#'
+        # - '#Unsafe usage of new static#'
 
     excludePaths:
         - ./*/*/FileToBeExcluded.php