Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update runtime to GNOME 47 #371

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update runtime to GNOME 47 #371

wants to merge 1 commit into from

Conversation

hfiguiere
Copy link
Collaborator

@hfiguiere hfiguiere commented Nov 9, 2024 •
edited
Loading

Close #361

@brunvonlope brunvonlope mentioned this pull request Nov 9, 2024
Open
@flathubbot
Copy link
Contributor

Started test build 160606

@hfiguiere
Copy link
Collaborator Author

I haven't build it locally. If the build fail I will fix it.

(I expect gcc to choke on WebKit)

@flathubbot
Copy link
Contributor

Build 160606 failed

@hfiguiere
Update runtime to GNOME 47
29b8fb6 
- Added new gtk2 patch (from shared-modules)

Signed-off-by: Hubert Figuière <[email protected]>
@hfiguiere
Copy link
Collaborator Author

Added a new patch to gtk2

@flathubbot
Copy link
Contributor

Started test build 160612

@flathubbot
Copy link
Contributor

Build 160612 failed

@hfiguiere
Copy link
Collaborator Author 

  CXX      Source/WTF/wtf/unicode/icu/libWTF_la-CollatorICU.lo
In file included from /usr/include/unicode/uset.h:36,
                 from /usr/include/unicode/unorm2.h:35,
                 from /usr/include/unicode/unorm.h:25,
                 from /usr/include/unicode/ucol.h:17,
                 from Source/WTF/wtf/unicode/icu/CollatorICU.cpp:37:
/usr/include/unicode/localpointer.h:561:26: error: parameter declared ‘auto’
  561 | template <typename Type, auto closeFunction>
      |                          ^~~~
/usr/include/unicode/localpointer.h:573:76: error: template argument 2 is invalid
  573 |     explicit LocalOpenPointer(std::unique_ptr<Type, decltype(closeFunction)> &&p)
      |                                                                            ^
/usr/include/unicode/localpointer.h:583:78: error: template argument 2 is invalid
  583 |     LocalOpenPointer &operator=(std::unique_ptr<Type, decltype(closeFunction)> &&p) {
      |                                                                              ^
/usr/include/unicode/localpointer.h:599:59: error: template argument 2 is invalid
  599 |     operator std::unique_ptr<Type, decltype(closeFunction)> () && {
      |                                                           ^
/usr/include/unicode/uset.h:358:1: note: invalid template non-type parameter
  358 | U_DEFINE_LOCAL_OPEN_POINTER(LocalUSetPointer, USet, uset_close);
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/unicode/unorm2.h:286:1: note: invalid template non-type parameter
  286 | U_DEFINE_LOCAL_OPEN_POINTER(LocalUNormalizer2Pointer, UNormalizer2, unorm2_close);
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/unicode/uenum.h:69:1: note: invalid template non-type parameter
   69 | U_DEFINE_LOCAL_OPEN_POINTER(LocalUEnumerationPointer, UEnumeration, uenum_close);
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/unicode/ucol.h:553:1: note: invalid template non-type parameter
  553 | U_DEFINE_LOCAL_OPEN_POINTER(LocalUCollatorPointer, UCollator, ucol_close);
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
make: *** [GNUmakefile:52948: Source/WTF/wtf/unicode/icu/libWTF_la-CollatorICU.lo] Error 1

@brunvonlope
Copy link
Collaborator

(I expect gcc to choke on WebKit)

@hfiguiere If this keeps being too hard to build, maybe would be doable to drop this specific dep. @Jehan partly authorized it: #71 (comment)

@AsciiWolf
Copy link

bot, build

@flathubbot
Copy link
Contributor

Queued test build for org.gimp.GIMP.

@flathubbot
Copy link
Contributor

Started test build 163689

@flathubbot
Copy link
Contributor

Build 163689 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update runtime to GNOME 47
4 participants
@hfiguiere @flathubbot @brunvonlope @AsciiWolf