Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: fails to get git submodule #537

Open
2 tasks done
solopasha opened this issue Mar 29, 2023 · 3 comments
Open
2 tasks done

[Bug]: fails to get git submodule #537

solopasha opened this issue Mar 29, 2023 · 3 comments

Comments

@solopasha
Copy link

Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

flatpak-builder version

1.3.3

Flatpak version

1.15.4

How to reproduce

  • create test.yml, try to build

test.yml

id: test
runtime: org.freedesktop.Platform
runtime-version: "22.08"
sdk: org.freedesktop.Sdk

modules:
  - name: test
    buildsystem: cmake-ninja
    builddir: true
    sources:
      - type: git
        url: https://github.com/TDesktop-x64/tdesktop.git
        commit: b5a138bfbe8d26d33ca7df1c6ed404ecfbecea02
        tag: v1.0.81

Expected Behavior

It should pull everything just like it would with git clone --recursive https://github.com/TDesktop-x64/tdesktop.git

Actual Behavior

❯ flatpak-builder build-dir test.yml                  
Downloading sources
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint: 
hint:   git config --global init.defaultBranch <name>
hint: 
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
hint: 'development'. The just-created branch can be renamed via this command:
hint: 
hint:   git branch -m <name>
Initialized empty Git repository in /home/solopasha/flatpak/test/.flatpak-builder/git/https_github.com_TDesktop-x64_tdesktop.git-4MYK21/
Fetching git repo https://github.com/TDesktop-x64/tdesktop.git, ref refs/tags/v1.0.81
remote: Enumerating objects: 3917, done.
remote: Counting objects: 100% (3917/3917), done.
remote: Compressing objects: 100% (3801/3801), done.
warning: object 92fbee05c936adf150b9f4f521cd19477fa28101: gitmodulesParse: could not parse gitmodules blob
remote: Total 3917 (delta 219), reused 2790 (delta 104), pack-reused 0
Receiving objects: 100% (3917/3917), 16.94 MiB | 3.34 MiB/s, done.
Resolving deltas: 100% (219/219), done.
From https://github.com/TDesktop-x64/tdesktop
 * [new tag]         v1.0.81    -> v1.0.81
Failed to download sources: module test: Key file contains line “[submodule "Telegram/ThirdParty/libtgvoip"]” which is not a key-value pair, group, or comment

Additional Information

No response

@solopasha solopasha added the bug label Mar 29, 2023
@TingPing
Copy link
Member

Did this work in 1.2.x?

@solopasha
Copy link
Author

Nope, errors out with the same message

@solopasha
Copy link
Author

this case is fixed in TDesktop-x64/tdesktop@57c01bb. Seems like flatpak-builder doesn't play well with Unicode text, UTF-8 (with BOM) text

@TingPing TingPing removed the bug label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants