Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

screenshots folder is no longer created in the builddir #573

Open
2 tasks done
tytan652 opened this issue Dec 10, 2023 · 2 comments · May be fixed by #576
Open
2 tasks done

screenshots folder is no longer created in the builddir #573

tytan652 opened this issue Dec 10, 2023 · 2 comments · May be fixed by #576

Comments

@tytan652
Copy link
Contributor

Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

flatpak-builder version

1.3.5

Flatpak version

1.15.4

How to reproduce

Use the flatpak/flatpak-github-actions with a mirror-screenshots-url set.

Expected Behavior

The build pass.

Actual Behavior

The build fails:

Committing screenshots...
Uploading artifact...
Starting artifact upload
For more detailed logs during the artifact upload process, enable step-debugging: https://docs.github.com/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging#enabling-step-debug-logging
Artifact name is valid!
/usr/bin/ostree commit --repo=repo --canonical-permissions --branch=screenshots/x86_64 flatpak_app/screenshots
error: opendir(flatpak_app/screenshots): No such file or directory
/__w/_actions/flatpak/flatpak-github-actions/0ab9dd6a6afa6fe7e292db0325171660bf5b6fdf/flatpak-builder/dist/index.js:7912
                error = new Error(`The process '${this.toolPath}' failed with exit code ${this.processExitCode}`);
                        ^

Error: The process '/usr/bin/ostree' failed with exit code 1
    at ExecState._setResult (/__w/_actions/flatpak/flatpak-github-actions/0ab9dd6a6afa6fe7e292db0325171660bf5b6fdf/flatpak-builder/dist/index.js:7912:25)
    at ExecState.CheckComplete (/__w/_actions/flatpak/flatpak-github-actions/0ab9dd6a6afa6fe7e292db0325171660bf5b6fdf/flatpak-builder/dist/index.js:7895:18)
    at ChildProcess.<anonymous> (/__w/_actions/flatpak/flatpak-github-actions/0ab9dd6a6afa6fe7e292db0325171660bf5b6fdf/flatpak-builder/dist/index.js:7789:27)
    at ChildProcess.emit (node:events:514:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

Additional Information

  • Fedora providing unstable flatpak-builder is triggerring issues flatpak-github-actions#168 was created on the actions repo.
  • I know that Fedora has already a bad stance with how they provide flatpak-builder version by providing unstable version.
  • flatpak-builder was creating the screenshot directory in builddir in version 1.3.3 (the one that was used to publish OBS Studio 30.0.0) but it looks like that got changed by libappstream port for some reason
@bbhtt
Copy link
Contributor

bbhtt commented Dec 11, 2023 •
edited
Loading

The old location was removed in e3e1233#diff-81460d46a2933ba7be79c8a9e9b7df7c28c7b6d867a80ae5436bbafd9108dbdaL2792 and a94517b#diff-a5328208d48d74071a8dbe8dda818b3188ad0cc1bdcd491761d097bd5c2c073dL958 It is now saved to builddir/share/app-info/media.

@bbhtt bbhtt mentioned this issue Dec 11, 2023
Open
hfiguiere added a commit to hfiguiere/flatpak-builder that referenced this issue Dec 28, 2023
@hfiguiere
builder-manifest: run appstream compose with --no-partial-urls
ac66435 
Only when mirroring. This is to be compatible with existing flatpak
deployment and appstream-glib

See ximion/appstream#505

Should fix flatpak#573

Signed-off-by: Hubert Figuière <[email protected]>
@hfiguiere hfiguiere linked a pull request Dec 28, 2023 that will close this issue
Draft
@hfiguiere hfiguiere moved this to In Review in @hfiguiere's xdg-portal Jan 21, 2024
hfiguiere added a commit to hfiguiere/flatpak-builder that referenced this issue Jan 23, 2024
@hfiguiere
builder-manifest: run appstreamcli compose with --no-partial-urls
9f9aa46 
Only when mirroring. This is to be compatible with existing flatpak
deployment and appstream-glib

See ximion/appstream#505

Should fix flatpak#573

Signed-off-by: Hubert Figuière <[email protected]>
hfiguiere added a commit to hfiguiere/flatpak-builder that referenced this issue Jan 23, 2024
@hfiguiere
builder-manifest: run appstreamcli compose with --no-partial-urls
c9f7ad0 
Only when mirroring. This is to be compatible with existing flatpak
deployment and appstream-glib

See ximion/appstream#505

Should fix flatpak#573

Signed-off-by: Hubert Figuière <[email protected]>
@TingPing
Copy link
Member

TingPing commented Feb 21, 2024 •
edited
Loading

For future reference the original logic was here: https://github.com/hughsie/appstream-glib/blob/d26446e437c9b82f3267ca22874f86f4a1954638/client/as-util.c#L3536-L3653

The media directory is not the same contents so we'll might have to recreate that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

builder-manifest: run appstream compose with --no-partial-urls hfiguiere/flatpak-builder
3 participants
@TingPing @tytan652 @bbhtt