-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOGL-7274: Asset Tracker not able to cope with assets that include sp… #911
base: develop
Are you sure you want to change the base?
Conversation
…ecial characters Signed-off-by: Innovative-ashwin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I assumed it would be simply a case of missing escape calls somewhere between the service and the database insert.
@Innovative-ashwin with above changes ingestion is good, but error in
Following are good though, Stats history dashboard /cc @MarkRiddoch |
Signed-off-by: Innovative-ashwin <[email protected]>
Merge branch 'FOGL-7274_new' of https://github.com/fledge-iot/fledge into FOGL-7274_new
@@ -1614,7 +1614,7 @@ vector<string> asset_codes; | |||
sql_cmd_base += ", asset_code"; | |||
|
|||
sql_cmd_base += ", id, reading, user_ts, ts "; | |||
StringReplaceAll (sql_cmd_base, "asset_code", " \"_assetcode_\" .assetcode. "); | |||
StringReplaceAll (sql_cmd_base, "asset_code", " '_assetcode_' .assetcode. "); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is causing issues now with ''
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test for following:
sin"1
sin"1"
sin'1
sin'1'
sin "#1'
sin :."',."''""`/1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failed for sin"1, sin"1", sin'1
@Innovative-ashwin Note that with commit 3e627b7 SQLIteLB is all good. |
Signed-off-by: Innovative-ashwin <[email protected]>
Signed-off-by: Innovative-ashwin <[email protected]>
Signed-off-by: Innovative-ashwin <[email protected]>
@Innovative-ashwin with the newest commit 9edfd59 sin"1 appears as 'sin"1' in assets and readings page; hence no graph rendered. Dashboard/Stats history and South page is good. (Same problem with used sin"1"2) sin'1 sin1'2" does not work; Asset and reading page breaks with storage plugin errors. This is for SQLite plugin. |
@Innovative-ashwin revert to this commit and take care of the reported issues please! |
closed by #970 |
…ecial characters
Signed-off-by: Innovative-ashwin [email protected]