Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templateAndroid.app_build_gradle Configuration Not Applied to /app/build.gradle #1808

Open
VictorThales opened this issue Nov 28, 2024 · 0 comments
Labels
question I have a question!

Comments

@VictorThales
Copy link

VictorThales commented Nov 28, 2024

Here’s a polished issue text for GitHub:


Title: templateAndroid.app_build_gradle Configuration Not Applied to /app/build.gradle


Description

I’m encountering an issue where configurations defined under the templateAndroid.app_build_gradle section of renative.json are not being applied to the generated /app/build.gradle file during the rnv configure process. This specifically affects the apply key within app_build_gradle, which is intended to add Gradle plugin applications.


Steps to Reproduce

  1. Define the following configuration in renative.json under the templateAndroid section for an appConfig:

    {
      "platforms": {
        "androidtv": {
          "templateAndroid": {
            "app_build_gradle": {
              "apply": ["apply plugin: 'com.google.gms.google-services'"]
            }
          }
        }
      }
    }
  2. Run the following command to configure the project:

    rnv configure -p androidtv
  3. Inspect the generated /platformBuilds/androidtv/app/build.gradle file.


Expected Behavior

The /app/build.gradle file should include the following line at the top:

apply plugin: 'com.google.gms.google-services'

Actual Behavior

The /app/build.gradle file does not contain the apply plugin line, and the configuration under app_build_gradle is ignored. Other parts of templateAndroid, such as buildscript.dependencies, work correctly.


Environment

  • ReNative Version: 1.0.0
  • Node.js Version: 18.20
  • OS: macOS 15.0
  • Platform: AndroidTV

Request

I would like to know:

  1. If the templateAndroid.app_build_gradle key is fully supported in the current version.
  2. If there are additional steps or configurations needed to enable this feature.
  3. If this is a bug

@VictorThales VictorThales added the question I have a question! label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question I have a question!
Projects
None yet
Development

No branches or pull requests

1 participant