You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Context: currently this library is released as 3 separate published JARs for the last 3 Apache Flink versions. For example:
1.18.1_1.2.0
1.19.1_1.2.0
1.20.0_1.2.0
Such approach make the release process quite slow, because it requires 3 bundles to be published to the Sonatype repository.
Also, it forces a user to think which version to select based on his Flink version used in a project. Not a big deal, but why bother with this?
Proposal:
Build and publish a single JAR only without Flink version prepended.
In order to keep Flink compatibility guarantees, still run sbt tests in GH Action for the last 3 Flink version as it is now.
In the result, this library gets verified across different Flink versions, but will have single version schema, which simplifies dependency management process for the users.
Caveats
What if build fails in one or two Flink version while it is still successful for one of the versions. This may happen in future with Flink 2.0 and Flink 1.x
The text was updated successfully, but these errors were encountered:
The risk I see in removing Flink versions from the bundle versioning is the inability to manage the breaking changes that will come with Flink 2.0.
By keeping separate builds and bundles, it will be possible to have different sources root for different Flink versions, as is already the case for Scala 2 and 3.
In case of a breaking change with a single bundle, it will be necessary either to:
no longer create new versions for Flink 1.x
maintain Flink 1.x on a separate branch, which will require more manual work in the end
In conclusion, I am not sure that this is the right time to make this simplification, and I find that the build time of less than 5 minutes is still acceptable.
Context: currently this library is released as 3 separate published JARs for the last 3 Apache Flink versions. For example:
Such approach make the release process quite slow, because it requires 3 bundles to be published to the Sonatype repository.
Also, it forces a user to think which version to select based on his Flink version used in a project. Not a big deal, but why bother with this?
Proposal:
Build and publish a single JAR only without Flink version prepended.
In order to keep Flink compatibility guarantees, still run sbt tests in GH Action for the last 3 Flink version as it is now.
In the result, this library gets verified across different Flink versions, but will have single version schema, which simplifies dependency management process for the users.
Caveats
The text was updated successfully, but these errors were encountered: