modify test workflow

flintforge · Nov 14, 2024 · dcd34d0 · dcd34d0
1 parent 9c22356
commit dcd34d0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 19 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -9,22 +9,6 @@ on:
     branches:
       - main
 
-services:
-  postgres:
-    image: postgres:latest
-    env:
-      POSTGRES_DB: pg
-      POSTGRES_PASSWORD: pg
-      POSTGRES_USER: pg
-    ports:
-      - 5432:5432
-    # Set health checks to wait until postgres has started
-    options: >-
-      --health-cmd pg_isready
-      --health-interval 10s
-      --health-timeout 5s
-      --health-retries 5
-
 jobs:
   test-builtin:
     runs-on: ubuntu-latest
@@ -39,6 +23,20 @@ jobs:
           - snapshot
         ignore_warnings:
           - true
+
+    services:
+      postgres:
+        image: postgres:latest
+        env:
+          POSTGRES_DB: pg
+          POSTGRES_PASSWORD: pg
+          POSTGRES_USER: pg
+        ports:
+          - 5432:5432
+        # Set health checks to wait until postgres has started
+        options: >-
+          --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
+
     steps:
     - uses: actions/checkout@v4
     - uses: purcell/setup-emacs@master

diff --git a/ob-sql-session-tests.el b/ob-sql-session-tests.el
@@ -159,12 +159,9 @@ sqlite|3.4
       (kill-this-buffer))))
 
 (defun pg-test (code expect &optional expected-result)
-  " can't connect to outside db from github for good reasons"
   (babel-block-test
    #'setup
-   ;; "sql :session PG::tests :engine postgres :dbhost localhost :database pg :dbuser pg :dbpassword pg :results raw"
    "sql :session PG::tests :engine postgres :dbhost localhost :database pg :dbuser pg :dbpassword pg :results raw"
-   ;; "sql :session PG::tests :engine postgres :dbhost hh-pgsql-public.ebi.ac.uk :database pfmegrnargs :dbuser reader :dbpassword NWDMCE5xdipIjRrp :results raw"
    code expect))
 
 (ert-deftest pg-000:test-session-var ()