Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronization fails when storing bookmarks in a Google Drive subfolder #1845

Closed
1 task done
Th-o-mas opened this issue Jan 26, 2025 · 4 comments
Closed
1 task done
Labels

Comments

@Th-o-mas
Copy link

Which version of floccus are you using?

5.4.3

How many bookmarks do you have, roughly?

10

Are you using other means to sync bookmarks in parallel to floccus?

Yes, I also sync via Mozilla account

Sync method

Google Drive

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Firefox 134.0.2 (Windows 10)

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

I first wrote this article in German and published it here:
https://app.gitter.im/#/room/#marcelklehr_floccus:gitter.im
I have translated my article with Deepl.

I have installed Floccus as an addon for Firefox under WIndows 10 and created the profile “Test”. The synchronization fails every time.

2025-01-24T19:50:45.564Z Starting sync process for account Test
2025-01-24T19:50:45.570Z onSyncStart: begin
2025-01-24T19:50:45.894Z onSyncFail
2025-01-24T19:50:45.895Z Syncing failed with d.files is undefined
2025-01-24T19:50:45.897Z onSyncFail

What does the fifth line in the log file mean?
My configuration: Connection with Google Drive, path to the bookmark file: Floccus\Test\bookmarks.xbel
Bookmark folder: /Bookmarks menu/Firefox custom bookmarks/Floccus/
However, the bookmark file is not created in Google Drive.

floccus-5.4.3-2025-01-25-full.log

After Marcels reply I moved the file and only entered “bookmarks.xbel” in the input field, the error message disappeared and the synchronization was successful.

I then moved bookmarks.xbel to the Floccus\Test\ folder and also entered this in the Floccus options. The synchronization fails with the same message.

  • What is the correct way to move the file bookmarks.xbel to Google Drive?

  • In the Floccus options it says “Path to bookmark file”. However, if no path may be entered there, would it perhaps make sense to name the option differently?

  • Would it be possible to change the error message “Syncing failed with d.files is undefined” so that (other) users know what is meant by “d.files”?

These are all just ideas from me. I am grateful that you have developed Floccus and made it available free of charge.

Expected Behavior

Successful synchronization and creation of the bookmark file in Google Drive

To Reproduce

I have installed Floccus as an addon for Firefox under WIndows 10 and created the profile “Test”. The synchronization fails every time.

My configuration:
Connection with Google Drive,
path to the bookmark file: Floccus\Test\bookmarks.xbel
Bookmark folder (in Firefox): /Bookmarks menu/Firefox custom bookmarks/Floccus/

Debug log provided

  • I have provided a debug log file
@Th-o-mas Th-o-mas added the bug label Jan 26, 2025
Copy link

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
To continue the development and maintenance of this project in a sustainable way I ask that you donate to the project when opening an issue
(or at least once your issue is solved), if you're not a donor already.
You can find donation options at https://floccus.org/donate/. Thank you!

One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

@marcelklehr
Copy link
Member

marcelklehr commented Jan 26, 2025

I then moved bookmarks.xbel to the Floccus\Test\ folder and also entered this in the Floccus options. The synchronization fails with the same message.

I think this is a misunderstanding. You shouldn't enter a path into the setting field. You should only enter the file name. The path of the file doesn't matter to floccus. It will always only look for the filename, regardless of where the file is.

I understand, however, that labelling the field "Bookmarks file path" is not ideal. I've changed this to just say "Bookmarks file"

marcelklehr added a commit that referenced this issue Jan 26, 2025
@Th-o-mas
Copy link
Author

Thanks for your feedback. I deleted the path from the input field and now the synchronization works :-) Thanks for your support!

I like your suggestion of labeling the field “Bookmarks file” and pointing out that the path in Google Drive does not matter and can therefore be arbitrary.

What do you think about the idea to change the error message “Syncing failed with d.files is undefined” so that (other) users know what is meant by “d.files”?

@marcelklehr
Copy link
Member

marcelklehr commented Jan 27, 2025

What do you think about the idea to change the error message “Syncing failed with d.files is undefined” so that (other) users know what is meant by “d.files”?

Yep, that's a good idea! The error message "d.files is undefined" is coming straight from the JavaScript interpreter so will be good to improve on that :)

@marcelklehr marcelklehr reopened this Jan 30, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Floccus Jan 31, 2025
@marcelklehr marcelklehr moved this from Backlog to To Do: Bugs in Floccus Jan 31, 2025
@github-project-automation github-project-automation bot moved this from To Do: Bugs to Done in Floccus Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants