Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move to standalone construct #1

Open
shishkin opened this issue Jul 17, 2022 · 2 comments
Open

feat: Move to standalone construct #1

shishkin opened this issue Jul 17, 2022 · 2 comments

Comments

@shishkin
Copy link

Thanks for putting this together. I came across this repo from aws/aws-cdk#12246.

I think it would be better to implement this construct as a stand-alone GSI construct instead of extending Table. That would make the listed caveats unnecessary as the user will be responsible to cleanly migrate indexes. It would also make the construct more stable in face of upstream Table class changes.

@flochaz
Copy link
Owner

flochaz commented Jul 18, 2022

Indeed, good idea , will do.

@flochaz flochaz changed the title Design suggestion feat: Move to standalone construct Jul 18, 2022
@francescoditrani
Copy link

francescoditrani commented Jul 21, 2022

Hi, thanks for the module, really needed! :)
I was wondering, would a standalone constructor also permit the creation/deletion of a single GSI with multiple existing GSIs?
Currently I'm only able to create-all or delete-all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants