From 3470e0b116a6ca3c0b13e48b72780bdee33df1d0 Mon Sep 17 00:00:00 2001
From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com>
Date: Wed, 21 Jun 2023 19:24:23 +0100
Subject: [PATCH] Ensure instantiation of hardware classes work for python
 bindings (#1058) (#1062)

(cherry picked from commit db34dfaf2d79fc8afcd460d9ae16f02c43265a2a)

Co-authored-by: Olivier Stasse <ostasse@laas.fr>
---
 hardware_interface/CMakeLists.txt             |  4 +++
 .../include/hardware_interface/system.hpp     |  2 ++
 .../test/test_inst_hardwares.cpp              | 34 +++++++++++++++++++
 3 files changed, 40 insertions(+)
 create mode 100644 hardware_interface/test/test_inst_hardwares.cpp

diff --git a/hardware_interface/CMakeLists.txt b/hardware_interface/CMakeLists.txt
index 9af1a359cd..2fb31641b0 100644
--- a/hardware_interface/CMakeLists.txt
+++ b/hardware_interface/CMakeLists.txt
@@ -122,6 +122,10 @@ if(BUILD_TESTING)
   target_include_directories(test_macros PRIVATE include)
   ament_target_dependencies(test_macros rcpputils)
 
+  ament_add_gmock(test_inst_hardwares test/test_inst_hardwares.cpp)
+  target_link_libraries(test_inst_hardwares hardware_interface)
+  ament_target_dependencies(test_inst_hardwares rcpputils)
+
   ament_add_gmock(test_joint_handle test/test_handle.cpp)
   target_link_libraries(test_joint_handle ${PROJECT_NAME})
   ament_target_dependencies(test_joint_handle rcpputils)
diff --git a/hardware_interface/include/hardware_interface/system.hpp b/hardware_interface/include/hardware_interface/system.hpp
index 4c9ae67ae2..ece14f814d 100644
--- a/hardware_interface/include/hardware_interface/system.hpp
+++ b/hardware_interface/include/hardware_interface/system.hpp
@@ -35,6 +35,8 @@ class SystemInterface;
 class System final
 {
 public:
+  System() = default;
+
   HARDWARE_INTERFACE_PUBLIC
   explicit System(std::unique_ptr<SystemInterface> impl);
 
diff --git a/hardware_interface/test/test_inst_hardwares.cpp b/hardware_interface/test/test_inst_hardwares.cpp
new file mode 100644
index 0000000000..ddd3aea0ad
--- /dev/null
+++ b/hardware_interface/test/test_inst_hardwares.cpp
@@ -0,0 +1,34 @@
+// Copyright 2023 LAAS CNRS
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include <gmock/gmock.h>
+
+#include "hardware_interface/actuator.hpp"
+#include "hardware_interface/actuator_interface.hpp"
+#include "hardware_interface/sensor.hpp"
+#include "hardware_interface/sensor_interface.hpp"
+#include "hardware_interface/system.hpp"
+#include "hardware_interface/system_interface.hpp"
+
+class TestInstantiationHardwares : public ::testing::Test
+{
+protected:
+  static void SetUpTestCase() {}
+};
+
+TEST_F(TestInstantiationHardwares, build_actuator) { hardware_interface::Actuator anActuator; }
+
+TEST_F(TestInstantiationHardwares, build_sensor) { hardware_interface::Sensor aSensor; }
+
+TEST_F(TestInstantiationHardwares, build_system) { hardware_interface::System aSystem; }