Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple proposal keys for regular users #195

Closed
uhbif19 opened this issue Oct 24, 2021 · 6 comments · Fixed by #235
Closed

Multiple proposal keys for regular users #195

uhbif19 opened this issue Oct 24, 2021 · 6 comments · Fixed by #235
Assignees
Labels
enhancement New feature or request

Comments

@uhbif19
Copy link

uhbif19 commented Oct 24, 2021

As far as I understand, a regular user cannot do his transactions concurrently.

Only admin can use multiple proposal keys. Is it possible to port this ability to an ordinary user?

@nanuuki nanuuki self-assigned this Dec 8, 2021
@nanuuki
Copy link
Contributor

nanuuki commented Dec 9, 2021

hi @uhbif19! you're correct. This is certainly a feature that can be added. Do you have any specifics regarding your use case?

The most straightforward way to do this would be to add an endpoint for adding keys to a specific account, for example for an existing account with 1 key:

POST /v1/accounts/{address}/add-keys HTTP/1.1
content-type: application/json

{
  "keyCount": 4
}

☝️ this would duplicate the main key for the account so that there would be a total of 1+4 = 5 copies of it (with key indexes 0-4).

Another option would be to specify the number of keys in the config and adding the keys at creation time for each new account.

I am assuming that the main purpose of this feature would be to allow concurrent transactions and as such the keys can be cloned instead of creating new private keys.

@nanuuki nanuuki added the enhancement New feature or request label Dec 9, 2021
@uhbif19
Copy link
Author

uhbif19 commented Dec 9, 2021

Thank you for the answer.

I did not know about add-keys, will try it.

Another option would be to specify the number of keys in the config and adding the keys at creation time for each new account.

I did not understand about option. Is that option is already usable?

Do you have any specifics regarding your use case?
I am assuming that the main purpose of this feature would be to allow concurrent transactions and

Yes, I want to do multiple transactions from the same account

@nanuuki
Copy link
Contributor

nanuuki commented Dec 9, 2021

@uhbif19 to clarify; the above are suggested implementation options, the /add-keys endpoint doesn't exist yet.

@sheerryy
Copy link

@nanuuki can we get any ETA for this feature?

@nanuuki
Copy link
Contributor

nanuuki commented Dec 13, 2021

@sheerryy I'm working on an initial implementation for this feature, it should be done pretty soon but latest next week :) The initial version will enable multiple keys for all custodial accounts, with a configurable number of keys (same for all custodial accounts that are created through the API).

@nanuuki nanuuki linked a pull request Dec 15, 2021 that will close this issue
@nanuuki
Copy link
Contributor

nanuuki commented Dec 20, 2021

@sheerryy @uhbif19 As #235 was merged it's now possible to configure new accounts to have more than one key. Hopefully this is useful to you :)

FYI: We're working on a feature to manually "sync" existing accounts to have the configured number of keys, no ETA on that yet though. Tracking this in #243.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants