Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Basic System Tests #1176

Merged
merged 16 commits into from
Nov 30, 2024
Merged

Conversation

gigalasr
Copy link
Collaborator

No description provided.

@gigalasr gigalasr linked an issue Nov 25, 2024 that may be closed by this pull request
@gigalasr
Copy link
Collaborator Author

@EagleoutIce Would you like me to add any of the examples you use often that you mentioned? If yes could you provide them?

@gigalasr
Copy link
Collaborator Author

@EagleoutIce How should the system tests be executed in the ci? SHould there be an extra step or should they be executed with test-full (change package.json) ?

@EagleoutIce
Copy link
Member

@EagleoutIce Would you like me to add any of the examples you use often that you mentioned? If yes could you provide them?

For now it is fine to test something like :df x <- 3 and :df "x <- 3\nprint(x)". I can do the rest.

@EagleoutIce
Copy link
Member

@EagleoutIce How should the system tests be executed in the ci? SHould there be an extra step or should they be executed with test-full (change package.json) ?

A separate step would be fine to have test:system or something like that. This should be not part of test-full but part of checkup

@gigalasr gigalasr marked this pull request as ready for review November 28, 2024 20:01
@EagleoutIce EagleoutIce merged commit 0a57e68 into main Nov 30, 2024
16 checks passed
@EagleoutIce EagleoutIce deleted the 1164-basic-system-tests-for-flowr branch November 30, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic System Tests for flowR
2 participants