Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxProfit throwing error #49

Open
marchtaylor opened this issue Sep 24, 2020 · 5 comments
Open

MaxProfit throwing error #49

marchtaylor opened this issue Sep 24, 2020 · 5 comments

Comments

@marchtaylor
Copy link
Contributor

I have been having difficulties setting up a MaxProfit fleet control scenario, which was throwing an error during the first fleet evaluated in the effort loop.

This same error occurs in the MaxProfit examples of the bio-economic Rmd tutorial (https://github.com/flr/doc/blob/master/FLBEIA_Bio_Economic_Tutorial.Rmd), e.g. chunk at L341, throws this error:

############################################################
-                   Year:  2017 , Season:  1 
############################################################
************ OPERATING MODEL***************************
------------ BIOLOGICAL OM ------------
-----------------ASPG-----------
-----------------ASPG-----------
-----------------ASPG-----------
-----------------ASPG-----------
-----------------ASPG-----------
------------ FLEETS OM ------------
[1] "~~~~~~~~~~ EFFORT ~~~~~~~~"
[1] "NTR_SP"
Error in FLObjs2S3_fleetSTD(biols = biols, fleets = fleets, advice = advice, : argument "adv.ss" is missing, with no default

Iago and I figured out that the Rmd still builds, but this is because those code chunks where FLBEIA is called are not evaluated (i.e. eval = FALSE).

The MaxProfit function does indeed fail to specify a value for the argument adv.ss in the call to FLObjs2S3_fleetSTD, so hopefully this is a relatively quick thing to fix.

If you could have a look at the tutorial and update the example as well, I would greatly appreciate it.

-Marc

@ssanchezAZTI
Copy link
Contributor

ssanchezAZTI commented Sep 25, 2020 via email

@marchtaylor
Copy link
Contributor Author

Thank you Sonia - much appreciated.

@ssanchezAZTI
Copy link
Contributor

ssanchezAZTI commented Sep 25, 2020 via email

@marchtaylor
Copy link
Contributor Author

Perfect. The tutorial example works for me as well. Thanks for the quick response.

@iagomosqueira
Copy link
Member

Let me know when you want the new package version released and the tutorial rerun and linked in the webpages. I would rather only place it online once the binary package is able to run it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants