Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original
Gleam
widget scheme didn't work properly withTabs
.There were different unwanted behaviors with different
TabsOverflow
handlers:Compress
: text from compressed tabs was rendering over other tabs. Also half of the frame border was rendering over other tabs.Pulldown
: text from any tab was rendering over pulldown button.The fix was to change
shade_rect_up()
function from instantly breaking loop:to just filling the rectangle (I believe it's meant to draw some kind of gradient, but I didn't understand it, sorry):
The tabs example is added, showing this problem was present and is now fixed.