out_prometheus_exporter: respond with 200 even with no metrics

fluent · Jan 5, 2024 · 79598c5 · 79598c5
1 parent cd497e3
commit 79598c5
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/plugins/out_prometheus_exporter/prom_http.c b/plugins/out_prometheus_exporter/prom_http.c
@@ -163,17 +163,17 @@ static void cb_metrics(mk_request_t *request, void *data)
     struct prom_http_buf *buf;
     (void) data;
 
+    mk_http_status(request, 200);
+    flb_hs_add_content_type_to_req(request, FLB_HS_CONTENT_TYPE_PROMETHEUS);
+
     buf = metrics_get_latest();
     if (!buf) {
-        mk_http_status(request, 404);
         mk_http_done(request);
         return;
     }
 
     buf->users++;
 
-    mk_http_status(request, 200);
-    flb_hs_add_content_type_to_req(request, FLB_HS_CONTENT_TYPE_PROMETHEUS);
     mk_http_send(request, buf->buf_data, buf->buf_size, NULL);
     mk_http_done(request);