Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naiive way to check for true in maps and config #490

Open
reduxdj opened this issue Oct 17, 2024 · 0 comments
Open

naiive way to check for true in maps and config #490

reduxdj opened this issue Oct 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@reduxdj
Copy link

reduxdj commented Oct 17, 2024

Describe the bug
madatory options should expect {"IceRestart": false} should not pass as true
Same with renegotiate... { "useUpdate" false"} should not evaluate as true

See renegotiate:

if (options['useUpdate'] != null) 

should be:

 if (options['useUpdate'] != null && options['useUpdate'] == true)

Expected behavior
Expected the config to work like any expected configuration

System Infomation()
Flutter SDK Version: 3.22
Target OS and Version: N/A
Host OS and Version: N/A

@reduxdj reduxdj added the bug Something isn't working label Oct 17, 2024
@reduxdj reduxdj changed the title naiive way to check for true config naiive way to check for true in maps and config Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant