Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rabbit resources jobspec update #158

Open
jameshcorbett opened this issue May 10, 2024 · 0 comments
Open

Rabbit resources jobspec update #158

jameshcorbett opened this issue May 10, 2024 · 0 comments

Comments

@jameshcorbett
Copy link
Member

jameshcorbett commented May 10, 2024

The dws-jobtap plugin grabs a reference to the user's jobspec and modifies it in an RPC callback.

The flux-core jobtap interface exposes a function flux_jobtap_jobspec_update_pack (flux_plugin_t *p, const char *fmt, ...). The dws-jobtap plugin should use that function (since it is part of the official interface) rather than relying on manipulation of the copy of jobspec held by the job manager. However, the function does not accept a jobid argument, which it would need to do in order to be used properly by dws-jobtap, since dws-jobtap does not modify the jobspec from within a jobtap callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant