-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
idea: kvs: support a native "EOF" #6455
Comments
This would imply an "eventlog_close()" or similar function would be required on eventlog writers? |
I haven't thought that far yet, but probably something like that. |
Job eventlogs could be "closed" when the job becomes inactive and the guest namespace is moved to the main namespace. However, many eventlogs don't really ever "close" (e.g. |
We were brainstorming about this yesterday and my first thought was to define an I think where you guys seem to be going is better - something like an end of file token that could be appended to a valref array. Then when a key is being watched wth the APPEND option, the streaming RPC could naturally terminate. Something like Seems like not a bad enhancement to the whole "append to a key" design space, which we kind of slapped together at the time. I think we should discuss whether it's helpful to our current code base before we jump in though. |
the job-info watcher knows it can stop watching certain keys when the job eventlog reaches its defined end
it could be convenient if there was a native "EOF" that could be added into the KVS, so such special handling wouldn't be necessary and the EOF could be used on other eventlogs (stdio, etc.)
The text was updated successfully, but these errors were encountered: