Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable performance analysis of Fluxion with PerfFlowAspect #1152

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tpatki
Copy link
Member

@tpatki tpatki commented Mar 7, 2024

Fixes #1146.

ToDo:

  • test/docker: Add bookworm Dockerfile with PFA installation.
  • Add libperfflow_runtime to fluxion CMake/build setup
  • Annotate resource, qmanager, traverser functions and test .pfw file generation
  • Determine which other functions to annotate for testing
  • Add scaling tests to measure flux-sched performance

@tpatki tpatki self-assigned this Mar 7, 2024
@tpatki tpatki force-pushed the fluxion_with_pfa branch from 4ee922d to 6c7ca5a Compare March 7, 2024 22:49
Problem: Enabling performance profiling of Fluxion requires
setting up PerfFlowAspect, which is not present in the
current setup.

Add a Dockerfile which builds and installs PerfFlowAspect.
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.0%. Comparing base (e5f6754) to head (39a4f53).

Current head 39a4f53 differs from pull request most recent head 2527281

Please upload reports for the commit 2527281 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1152     +/-   ##
========================================
- Coverage    74.1%   71.0%   -3.1%     
========================================
  Files         103      96      -7     
  Lines       14518   12867   -1651     
========================================
- Hits        10765    9147   -1618     
+ Misses       3753    3720     -33     

see 58 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance Data Collection for Fluxion
1 participant