cmake: clarify git-push suggestion #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: it was pointed out that the git-push--tags suggestion is a wee bit confusing. Solution: clarify that this should only be done to a fork, and is usually only helpful in remote CI.
wihobbs
added
the
merge-when-passing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1295 +/- ##
======================================
Coverage 75.3% 75.3%
======================================
Files 110 110
Lines 15236 15236
======================================
Hits 11486 11486
Misses 3750 3750 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@garlick pointed out in flux-framework/flux-core#6276 that the suggestion to
git push --tagsis a wee bit confusing, so I wanted to clarify in this one to stay consistent.