Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmanager: track API changes in core #1320

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

garlick
Copy link
Member

@garlick garlick commented Dec 10, 2024

Problem: the raw RPC interfaces are changing to use a size_t instead of int for payload size.

Update scheduler usage.

flux-framework/flux-core#6467 must be merged before this will pass CI.

Problem: the raw RPC interfaces are changing to use a size_t
instead of int for payload size.

Update scheduler usage.

flux-framework/flux-core#6467 must be merged before this will pass CI.
Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garlick garlick added the merge-when-passing mergify.io - merge PR automatically once CI passes label Dec 11, 2024
@mergify mergify bot merged commit 3fb0b4e into flux-framework:master Dec 11, 2024
21 checks passed
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.5%. Comparing base (6a7ecc0) to head (139d021).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1320      +/-   ##
=========================================
+ Coverage    75.2%   82.5%    +7.3%     
=========================================
  Files         111      32      -79     
  Lines       15986    4183   -11803     
=========================================
- Hits        12029    3455    -8574     
+ Misses       3957     728    -3229     

see 85 files with indirect coverage changes

@garlick garlick deleted the use_size_t branch December 11, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mergify.io - merge PR automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants