Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pretty print fixpoint constraints by default #858

Open
nilehmann opened this issue Oct 22, 2024 · 1 comment
Open

Do not pretty print fixpoint constraints by default #858

nilehmann opened this issue Oct 22, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@nilehmann
Copy link
Member

nilehmann commented Oct 22, 2024

We currently pretty print fixpoint horn constraints in the Display implementation, i.e., we add newlines and indentation to make the sexpr easier to read. This is wasteful if we are not looking at the constraint and it has caused problems in the past (e.g., #857 (comment)). I still think is valuable to pretty print them in cases where we do look at them. We should disable pretty printing by default and implement a flag to enable it on demand.

Additionally, the PadAdapter is probably not the most efficient implementation. We could use normal functions instead of implementing Display to avoid wrapping the formatter to get the padding behavior.

@nilehmann nilehmann added the good first issue Good for newcomers label Oct 22, 2024
@nilehmann
Copy link
Member Author

PadAdapter was removed in c5a037f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant