-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links in API docs #1200
Merged
Merged
Fix links in API docs #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingdonb
pushed a commit
to kingdonb/notification-controller
that referenced
this pull request
Aug 15, 2023
Another commit to go with: * fluxcd/source-controller#1200 Signed-off-by: Kingdon Barrett <[email protected]>
kingdonb
changed the title
To go with fluxcd/website#1621 (2/?)
To go with fluxcd/website#1621 (1/3)
Aug 15, 2023
These are all independent fixes and they can be merged without any other dependency. This will update the website |
kingdonb
pushed a commit
to fluxcd/website
that referenced
this pull request
Aug 15, 2023
* https://github.com/kingdonb/link-checker-gpt/actions/runs/5870914877 Test here showed these issues standing in the way of a green checkmark There are still a few more fixes through: * fluxcd/source-controller#1200 Signed-off-by: Kingdon Barrett <[email protected]>
This was referenced Aug 15, 2023
stefanprodan
pushed a commit
to fluxcd/website
that referenced
this pull request
Aug 17, 2023
* https://github.com/kingdonb/link-checker-gpt/actions/runs/5870914877 Test here showed these issues standing in the way of a green checkmark There are still a few more fixes through: * fluxcd/source-controller#1200 Signed-off-by: Kingdon Barrett <[email protected]>
stefanprodan
changed the title
To go with fluxcd/website#1621 (1/3)
Fix links in API docs
Aug 22, 2023
@kingdonb please squash, rename the commit to "Fix links in API docs" and rebase. Thanks |
kingdonb
force-pushed
the
fix-bad-links
branch
from
August 22, 2023 11:14
4014e89
to
082c7cf
Compare
stefanprodan
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more rebase please
Signed-off-by: Kingdon Barrett <[email protected]>
kingdonb
force-pushed
the
fix-bad-links
branch
from
August 22, 2023 11:28
082c7cf
to
79eedb3
Compare
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/docs
Documentation related issues and pull requests
backport:release/v1.0.x
To be backported to release/v1.0.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes all go together:
I will add any further ancillary PRs to this one, and we can coordinate the merges from here. Now we are closing in on the end of the list of changes we needed, in order to finalize fluxcd/website#1573 without creating any regressions.