Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in API docs #1200

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Fix links in API docs #1200

merged 1 commit into from
Aug 22, 2023

Conversation

kingdonb
Copy link
Member

@kingdonb kingdonb commented Aug 15, 2023

These changes all go together:

I will add any further ancillary PRs to this one, and we can coordinate the merges from here. Now we are closing in on the end of the list of changes we needed, in order to finalize fluxcd/website#1573 without creating any regressions.

kingdonb pushed a commit to kingdonb/notification-controller that referenced this pull request Aug 15, 2023
Another commit to go with:
* fluxcd/source-controller#1200

Signed-off-by: Kingdon Barrett <[email protected]>
@kingdonb kingdonb changed the title To go with fluxcd/website#1621 (2/?) To go with fluxcd/website#1621 (1/3) Aug 15, 2023
@kingdonb kingdonb marked this pull request as ready for review August 15, 2023 19:47
@kingdonb
Copy link
Member Author

These are all independent fixes and they can be merged without any other dependency.

This will update the website

kingdonb pushed a commit to fluxcd/website that referenced this pull request Aug 15, 2023
* https://github.com/kingdonb/link-checker-gpt/actions/runs/5870914877
Test here showed these issues standing in the way of a green checkmark

There are still a few more fixes through:

* fluxcd/source-controller#1200

Signed-off-by: Kingdon Barrett <[email protected]>
stefanprodan pushed a commit to fluxcd/website that referenced this pull request Aug 17, 2023
* https://github.com/kingdonb/link-checker-gpt/actions/runs/5870914877
Test here showed these issues standing in the way of a green checkmark

There are still a few more fixes through:

* fluxcd/source-controller#1200

Signed-off-by: Kingdon Barrett <[email protected]>
@stefanprodan stefanprodan changed the title To go with fluxcd/website#1621 (1/3) Fix links in API docs Aug 22, 2023
@stefanprodan stefanprodan added the area/docs Documentation related issues and pull requests label Aug 22, 2023
@stefanprodan
Copy link
Member

@kingdonb please squash, rename the commit to "Fix links in API docs" and rebase. Thanks

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more rebase please

Signed-off-by: Kingdon Barrett <[email protected]>
@stefanprodan stefanprodan merged commit de31a12 into fluxcd:main Aug 22, 2023
@kingdonb kingdonb deleted the fix-bad-links branch August 22, 2023 11:44
@makkes makkes added the backport:release/v1.0.x To be backported to release/v1.0.x label Aug 22, 2023
@fluxcdbot
Copy link
Member

Successfully created backport PR for release/v1.0.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation related issues and pull requests backport:release/v1.0.x To be backported to release/v1.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants