Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(quotes): Add double-quotes for REDIS_PASSWORD #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(quotes): Add double-quotes for REDIS_PASSWORD #18

wants to merge 2 commits into from

Commits on Jan 4, 2024

  1. fix(quotes): Add double-quotes for REDIS_PASSWORD 

    This allows special characters to be used, fixing:
fly-apps#3

It will also ensure that the resulting server instance remains
accessible when the password has special characters.

Had to double-quote the `redis-server` password argument, and escape the
double quotes in `PW_ARG`, to make sure it was assigned correctly.

Signed-off-by: Dom Rodriguez <[email protected]>
    @shymega
    shymega committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    14b166e View commit details
    Browse the repository at this point in the history

  2. fix(doublequotes): Double-quote remaining variables 

    This should prevent issues with whitespace, or globbing-related issues.

Signed-off-by: Dom Rodriguez <[email protected]>
    @shymega
    shymega committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    6eab9ac View commit details
    Browse the repository at this point in the history