This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Fix mutating extant resources not forcing new #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 2.9.1 to 3.0.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@v2.9.1...v3.0.0) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Closes fly-apps#2 Closes fly-apps#14
Token parameter & env were renamed
Towards fly-apps#42
Update references to fly API token env variable
Closes fly-apps#85
Import certs with app_id,hostname ids
This reverts commit a92ca86.
…quired Make app required for machine resources
Log machine create http errors
OJFord
force-pushed
the
fix-mutate-errors
branch
from
d62360f to
ac1a0bc
Compare
OJFord
force-pushed
the
fix-mutate-errors
branch
from
ac1a0bc to
e2425a7
Compare
OJFord
commented
Feb 23, 2023
| @@ -168,8 +168,11 @@ func (mr flyMachineResourceType) GetSchema(context.Context) (tfsdk.Schema, diag. | |||
| }, | |||
| "volume": { | |||
| Required: true, | |||
| MarkdownDescription: "Name or ID of volume", | |||
| MarkdownDescription: "ID of volume", | |||
There was a problem hiding this comment.
If name did work it technically still will, I just suggest not documenting it because the ID will work better - it will change if the fly_volume is replaced, so we'll detect the change here; if it's recreated with the same name then that wouldn't have changed and wouldn't force a replacement here, so better to use ID.
|
Closed due to history re-write, but refiled as #190 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154, #19 (comment).