Not being notified when N+1 is detected in turbo frame or turbo stream

[tpaulshippy]

I'm not sure if this belongs as an issue in https://github.com/flyerhzm/uniform_notifier or here.

Our team makes heavy use of Turbo in our applications. We have been dealing with a lot of N+1 issues that Sentry is able to detect but Bullet is not always alerting us to them at development time. One of the reasons we have noticed is that Bullet will not notify us when there is an issue with a request that is either streamed back via turbo stream or just on a navigation that is shown in a turbo frame.

I have created a branch in my playground app to illustrate the issue.
Despite having the following in my development.rb --

  config.after_initialize do
    Bullet.enable        = true
    Bullet.alert         = true
    Bullet.bullet_logger = true
    Bullet.console       = true
    Bullet.rails_logger  = true
    Bullet.add_footer    = true
  end

I am not seeing any indication that there is an issue unless I examine my server logs in my terminal.

This commit shows the issue with streams.
And this commit shows the issue with frames.

Here is a screen recording of the issue --

bullet-turbo-issue-smaller.mov

The only "workaround" for this is:

    Bullet.raise         = true

[flyerhzm]

@tpaulshippy bullet frontend notification only works in html response, turbo doesn't provide any means to execute JS

[tpaulshippy]

The funny thing about that statement is that turbo is written in javascript. 😁

But yeah I get it that there is not an easy solution here. Even if it was just intercepting the request and returning "Content missing" like rails does with a lot of turbo issues, that would be better.

I'm not sure why bullet couldn't stream back the warning through turbo. Or provide a turbo client side event hook that detects something in the response and does the alert. I'll work on something.

[flyerhzm]

@tpaulshippy bullet injects the html response in lib/bullet/rack.rb, you can add the turbo stream support here.

[tpaulshippy]

Great. I'll start there. Thanks.

[tpaulshippy]

Code in this branch seems to be working. I'll try to work on a PR with tests at some point.

Decided to just timebox it and got it done.