Fix unused component detection #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zagy
force-pushed
the
fix-dependency-error
branch
from
d1c7a03
to
2a9b427
Compare
zagy
force-pushed
the
fix-dependency-error
branch
3 times, most recently
from
9882aec
to
418ba66
Compare
There was a bug in unused component detection which was triggered occasionally. It is not entirely clear what triggered it, but it "helped" to have a lot of components.
zagy
force-pushed
the
fix-dependency-error
branch
from
418ba66
to
367dd87
Compare
zagy
commented
Nov 18, 2024
| [s.root for s in self._subscriptions(resource, None)] | ||
| [s.root for s in self._subscriptions(resource, host)] |
There was a problem hiding this comment.
I think this is what actually fixed the bug :)
ctheune
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in unused component detection which was triggered occasionally. It is not entirely clear what triggered it, but it "helped" to have a lot of components.