Skip to content

Commit

Permalink
fix(migrations): Correct NULL to empty string in SQL insert (#5482)
Browse files Browse the repository at this point in the history
  • Loading branch information
pingsutw authored Jun 17, 2024
1 parent 59e18d1 commit 1abdd94
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/single-binary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ jobs:
- name: Install Python dependencies
run: |
python -m pip install --upgrade pip
pip install flytekit flytekitplugins-deck-standard
pip install flytekit flytekitplugins-deck-standard "numpy<2.0.0"
pip freeze
- name: Checkout flytesnacks
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion flyteadmin/pkg/repositories/config/migrations.go
Original file line number Diff line number Diff line change
Expand Up @@ -1250,7 +1250,7 @@ var ContinuedMigrations = []*gormigrate.Migration{
// Drop execution_admin_tags and admin_tags tables, and create a new table execution_tags
// to store tags associated with executions.
sql := "INSERT INTO execution_tags (execution_project, execution_domain, execution_name, created_at, updated_at, deleted_at, key, value)" +
" SELECT execution_project, execution_domain, execution_name, created_at, updated_at, deleted_at, name as key, null as value" +
" SELECT execution_project, execution_domain, execution_name, created_at, updated_at, deleted_at, name as key, '' as value" +
" FROM execution_admin_tags" +
" INNER JOIN admin_tags a on execution_admin_tags.admin_tag_id = a.id;"
if err := tx.Exec(sql).Error; err != nil {
Expand Down

0 comments on commit 1abdd94

Please sign in to comment.