Update documentation with new flyte-core chart default values

Signed-off-by: Julian Einhaus <[email protected]>
flyteorg · Apr 8, 2024 · 276679c · 276679c
1 parent acd2f85
commit 276679c
Show file tree

Hide file tree

Showing 9 changed files with 309 additions and 218 deletions.
diff --git a/charts/flyte-core/README.md b/charts/flyte-core/README.md
@@ -175,7 +175,7 @@ helm install gateway bitnami/contour -n flyte
 | flyteadmin.resources | object | `{"limits":{"cpu":"250m","ephemeral-storage":"100Mi","memory":"500Mi"},"requests":{"cpu":"10m","ephemeral-storage":"50Mi","memory":"50Mi"}}` | Default resources requests and limits for Flyteadmin deployment |
 | flyteadmin.secrets | object | `{}` |  |
 | flyteadmin.securityContext | object | `{"fsGroup":65534,"fsGroupChangePolicy":"Always","runAsNonRoot":true,"runAsUser":1001,"seLinuxOptions":{"type":"spc_t"}}` | Sets securityContext for flyteadmin pod(s). |
-| flyteadmin.service | object | `{"annotations":{"projectcontour.io/upstream-protocol.h2c":"grpc"},"loadBalancerSourceRanges":[],"type":"ClusterIP"}` | Service settings for Flyteadmin |
+| flyteadmin.service | object | `{"annotations":{},"grpcAnnotations":{},"httpAnnotations":{},"loadBalancerSourceRanges":[],"type":"ClusterIP"}` | Service settings for Flyteadmin |
 | flyteadmin.serviceAccount | object | `{"alwaysCreate":false,"annotations":{},"clusterRole":{"apiGroups":["","flyte.lyft.com","rbac.authorization.k8s.io"],"resources":["configmaps","flyteworkflows","namespaces","pods","resourcequotas","roles","rolebindings","secrets","services","serviceaccounts","spark-role","limitranges"],"verbs":["*"]},"create":true,"createClusterRole":true,"imagePullSecrets":[]}` | Configuration for service accounts for FlyteAdmin |
 | flyteadmin.serviceAccount.alwaysCreate | bool | `false` | Should a service account always be created for flyteadmin even without an actual flyteadmin deployment running (e.g. for multi-cluster setups) |
 | flyteadmin.serviceAccount.annotations | object | `{}` | Annotations for ServiceAccount attached to Flyteadmin pods |

diff --git a/deployment/eks/flyte_aws_scheduler_helm_generated.yaml b/deployment/eks/flyte_aws_scheduler_helm_generated.yaml
@@ -726,6 +726,28 @@ subjects:
     name: flyte-pod-webhook
     namespace: flyte
 ---
+# Source: flyte-core/templates/admin/service-grpc.yaml
+apiVersion: v1
+kind: Service
+metadata:
+  name: flyteadmin-grpc
+  namespace: flyte
+  labels: 
+    app.kubernetes.io/name: flyteadmin
+    app.kubernetes.io/instance: flyte
+    helm.sh/chart: flyte-core-v0.1.10
+    app.kubernetes.io/managed-by: Helm
+spec:
+  type: ClusterIP
+  ports:
+    - name: grpc
+      port: 81
+      protocol: TCP
+      targetPort: grpc
+  selector: 
+    app.kubernetes.io/name: flyteadmin
+    app.kubernetes.io/instance: flyte
+---
 # Source: flyte-core/templates/admin/service.yaml
 apiVersion: v1
 kind: Service
@@ -737,19 +759,13 @@ metadata:
     app.kubernetes.io/instance: flyte
     helm.sh/chart: flyte-core-v0.1.10
     app.kubernetes.io/managed-by: Helm
-  annotations: 
-    projectcontour.io/upstream-protocol.h2c: grpc
 spec:
   type: ClusterIP
   ports:
     - name: http
       port: 80
       protocol: TCP
-      targetPort: 8088
-    - name: grpc
-      port: 81
-      protocol: TCP
-      targetPort: 8089
+      targetPort: http
     - name: redoc
       protocol: TCP
       port: 87
@@ -957,9 +973,12 @@ spec:
         imagePullPolicy: "IfNotPresent"
         name: flyteadmin
         ports:
-        - containerPort: 8088
-        - containerPort: 8089
-        - containerPort: 10254
+        - name: http
+          containerPort: 8088
+        - name: grpc
+          containerPort: 8089
+        - name: profiler
+          containerPort: 10254
         readinessProbe:
           exec:
             command: [ "sh", "-c", "reply=$(curl -s -o /dev/null -w %{http_code} http://127.0.0.1:8088/healthcheck); if [ \"$reply\" -lt 200 -o \"$reply\" -ge 400 ]; then exit 1; fi;","grpc_health_probe", "-addr=:8089"]
@@ -1633,89 +1652,88 @@ spec:
           #   path: /*
           #   pathType: ImplementationSpecific
           #
-
           # NOTE: Port 81 in flyteadmin is the GRPC server port for FlyteAdmin.
-          - path: /flyteidl.service.SignalService
+          - path: /flyteidl.service.AdminService
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
-          - path: /flyteidl.service.SignalService/*
+          - path: /flyteidl.service.AdminService/*
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
-          - path: /flyteidl.service.AdminService
+          - path: /flyteidl.service.AuthMetadataService
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
-          - path: /flyteidl.service.AdminService/*
+          - path: /flyteidl.service.AuthMetadataService/*
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
           - path: /flyteidl.service.DataProxyService
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
           - path: /flyteidl.service.DataProxyService/*
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
-          - path: /flyteidl.service.AuthMetadataService
+          - path: /flyteidl.service.IdentityService
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
-          - path: /flyteidl.service.AuthMetadataService/*
+          - path: /flyteidl.service.IdentityService/*
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
-          - path: /flyteidl.service.IdentityService
+          - path: /flyteidl.service.SignalService
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
-          - path: /flyteidl.service.IdentityService/*
+          - path: /flyteidl.service.SignalService/*
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
           - path: /grpc.health.v1.Health
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
           - path: /grpc.health.v1.Health/*
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
diff --git a/deployment/eks/flyte_helm_controlplane_generated.yaml b/deployment/eks/flyte_helm_controlplane_generated.yaml
@@ -449,6 +449,28 @@ subjects:
   name: flyteadmin
   namespace: flyte
 ---
+# Source: flyte-core/templates/admin/service-grpc.yaml
+apiVersion: v1
+kind: Service
+metadata:
+  name: flyteadmin-grpc
+  namespace: flyte
+  labels: 
+    app.kubernetes.io/name: flyteadmin
+    app.kubernetes.io/instance: flyte
+    helm.sh/chart: flyte-core-v0.1.10
+    app.kubernetes.io/managed-by: Helm
+spec:
+  type: ClusterIP
+  ports:
+    - name: grpc
+      port: 81
+      protocol: TCP
+      targetPort: grpc
+  selector: 
+    app.kubernetes.io/name: flyteadmin
+    app.kubernetes.io/instance: flyte
+---
 # Source: flyte-core/templates/admin/service.yaml
 apiVersion: v1
 kind: Service
@@ -460,19 +482,13 @@ metadata:
     app.kubernetes.io/instance: flyte
     helm.sh/chart: flyte-core-v0.1.10
     app.kubernetes.io/managed-by: Helm
-  annotations: 
-    projectcontour.io/upstream-protocol.h2c: grpc
 spec:
   type: ClusterIP
   ports:
     - name: http
       port: 80
       protocol: TCP
-      targetPort: 8088
-    - name: grpc
-      port: 81
-      protocol: TCP
-      targetPort: 8089
+      targetPort: http
     - name: redoc
       protocol: TCP
       port: 87
@@ -662,9 +678,12 @@ spec:
         imagePullPolicy: "IfNotPresent"
         name: flyteadmin
         ports:
-        - containerPort: 8088
-        - containerPort: 8089
-        - containerPort: 10254
+        - name: http
+          containerPort: 8088
+        - name: grpc
+          containerPort: 8089
+        - name: profiler
+          containerPort: 10254
         readinessProbe:
           exec:
             command: [ "sh", "-c", "reply=$(curl -s -o /dev/null -w %{http_code} http://127.0.0.1:8088/healthcheck); if [ \"$reply\" -lt 200 -o \"$reply\" -ge 400 ]; then exit 1; fi;","grpc_health_probe", "-addr=:8089"]
@@ -1253,89 +1272,88 @@ spec:
           #   path: /*
           #   pathType: ImplementationSpecific
           #
-
           # NOTE: Port 81 in flyteadmin is the GRPC server port for FlyteAdmin.
-          - path: /flyteidl.service.SignalService
+          - path: /flyteidl.service.AdminService
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
-          - path: /flyteidl.service.SignalService/*
+          - path: /flyteidl.service.AdminService/*
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
-          - path: /flyteidl.service.AdminService
+          - path: /flyteidl.service.AuthMetadataService
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
-          - path: /flyteidl.service.AdminService/*
+          - path: /flyteidl.service.AuthMetadataService/*
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
           - path: /flyteidl.service.DataProxyService
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
           - path: /flyteidl.service.DataProxyService/*
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
-          - path: /flyteidl.service.AuthMetadataService
+          - path: /flyteidl.service.IdentityService
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
-          - path: /flyteidl.service.AuthMetadataService/*
+          - path: /flyteidl.service.IdentityService/*
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
-          - path: /flyteidl.service.IdentityService
+          - path: /flyteidl.service.SignalService
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
-          - path: /flyteidl.service.IdentityService/*
+          - path: /flyteidl.service.SignalService/*
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
           - path: /grpc.health.v1.Health
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81
           - path: /grpc.health.v1.Health/*
             pathType: ImplementationSpecific
             backend:
               service:
-                name: flyteadmin
+                name: flyteadmin-grpc
                 port:
                   number: 81