Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - pyflyte run with custom image option is not using the specified image #3643

Open
2 tasks done
mitzen opened this issue May 6, 2023 · 3 comments
Open
2 tasks done
Labels
bug Something isn't working flytekit FlyteKit Python related issue stale

Comments

@mitzen
Copy link

mitzen commented May 6, 2023

Describe the bug

i am trying to register my workflow to flyte sandbox environment, using the following command:

pyflyte register workflows --image ghcr.io/flyteorg/flytekit:py3.11-sqlalchemy-1.6.0b0

This image exist https://github.com/flyteorg/flytekit/pkgs/container/flytekit/86821037?tag=py3.11-sqlalchemy-1.6.0b0

I can see that the workflow is registered. However, when i look at the image, it is defaulted to

cr.flyte.org/flyteorg/flytekit:py3.11-sqlalchemy-1.5.0

might have been a parsing error here, missing out gr in cr.flyte.org/flyteorg/flytekit:py3.11-sqlalchemy-1.5.0

Please have a look at the screenshot below:-

Expected behavior

workflow should be using the image given in the cli

Additional context to reproduce

  1. Use the sample code that was given here https://raw.githubusercontent.com/flyteorg/flytesnacks/master/cookbook/integrations/flytekit_plugins/sql/sql_alchemy.py
  2. Then try to register the workflow using "pyflyte register workflows --image ghcr.io/flyteorg/flytekit:py3.11-sqlalchemy-1.6.0b"
  3. Go to the web ui and look at the task details, expand the tree, goto -> container -> image name

Screenshots

flyte-image-web

Registration was made for image ghcr.io/flyteorg/flytekit:py3.11-sqlalchemy-1.6.0b0

register-flyte-workflow

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@mitzen mitzen added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels May 6, 2023
@welcome
Copy link

welcome bot commented May 6, 2023

Thank you for opening your first issue here! 🛠

@eapolinario eapolinario added flytekit FlyteKit Python related issue and removed untriaged This issues has not yet been looked at by the Maintainers labels May 12, 2023
@Future-Outlier
Copy link
Member

I've reproduced it, here's my opinion.
"pyflyte register" allows the workflow to run the specified image, but the image name will not be changed.

Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue stale
Projects
None yet
Development

No branches or pull requests

3 participants