-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC - Flyte Console UI Upgrade #3755
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed changes look good to me.
I would like to propose one additional improvement:
I often work on a 13 inch macbook without an external monitor. On such a screen size the version string is only partly visible. When one hovers over it with the mouse, the full string is not shown. Initially I didn't know a better way other than zooming out in the browser to see the full version. Now I discovered that one can mark the visible part of the version but copy the entire version. I wished that there was a better way to see the full version when the screen size is limited.
@fg91 Thank you for your response and feedback. I am in the early stages of a redesign of the layout of the execution page view and will include your concerns in my thinking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
Slightly perpendicular, but I can only second what Fabio has said about it being nice to also test against small (13 inch?) screens :-)
03-08-2023 Contributors sync notes: already implemented. |
Congrats on merging your first pull request! 🎉 |
Describe your changes
The proposal is to do a modest branding, orientation & navigation enhancement to the Flyte Console:
Screenshots
Please review the RFC for details and illustrations.
Note to reviewers