Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC - Flyte Console UI Upgrade #3755

Merged
merged 5 commits into from
Aug 3, 2023
Merged

RFC - Flyte Console UI Upgrade #3755

merged 5 commits into from
Aug 3, 2023

Conversation

tsheiner
Copy link
Contributor

@tsheiner tsheiner commented Jun 7, 2023

Describe your changes

The proposal is to do a modest branding, orientation & navigation enhancement to the Flyte Console:

  1. move the application header to the left side of the viewport
  2. introduce consistent bread crumb element on all pages
  3. introduce consistent page header on all pages
  4. enable the bread crumb & page header elements to also function as navigation controls

Screenshots

Please review the RFC for details and illustrations.

Note to reviewers

@welcome
Copy link

welcome bot commented Jun 7, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@davidmirror-ops davidmirror-ops added the rfc A label for RFC issues label Jun 7, 2023
Copy link
Member

@fg91 fg91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes look good to me.

I would like to propose one additional improvement:

Screenshot_2023-06-08_at_19_20_18

I often work on a 13 inch macbook without an external monitor. On such a screen size the version string is only partly visible. When one hovers over it with the mouse, the full string is not shown. Initially I didn't know a better way other than zooming out in the browser to see the full version. Now I discovered that one can mark the visible part of the version but copy the entire version. I wished that there was a better way to see the full version when the screen size is limited.

@tsheiner
Copy link
Contributor Author

tsheiner commented Jun 8, 2023

@fg91 Thank you for your response and feedback. I am in the early stages of a redesign of the layout of the execution page view and will include your concerns in my thinking.

Copy link
Member

@bstadlbauer bstadlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Slightly perpendicular, but I can only second what Fabio has said about it being nice to also test against small (13 inch?) screens :-)

@davidmirror-ops
Copy link
Contributor

03-08-2023 Contributors sync notes: already implemented.

@davidmirror-ops davidmirror-ops merged commit 1f3f6f2 into flyteorg:master Aug 3, 2023
@welcome
Copy link

welcome bot commented Aug 3, 2023

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc A label for RFC issues
Projects
Status: Implemented
Development

Successfully merging this pull request may close these issues.

4 participants