Skip to content

Add domain matric, add test in flyteadmin and flytectl

Codecov / codecov/project succeeded Jun 7, 2024 in 0s

61.07% (-0.01%) compared to 25c3596, passed because coverage increased by -0.01% when compared to adjusted base (61.07%)

View this Pull Request on Codecov

61.07% (-0.01%) compared to 25c3596, passed because coverage increased by -0.01% when compared to adjusted base (61.07%)

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 61.07%. Comparing base (25c3596) to head (b268533).

Current head b268533 differs from pull request most recent head 690a7f8

Please upload reports for the commit 690a7f8 to get more accurate results.

Files Patch % Lines
flyteadmin/pkg/rpc/adminservice/project.go 0.00% 10 Missing ⚠️
flytectl/pkg/ext/domain_fetcher.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5443      +/-   ##
==========================================
- Coverage   61.07%   61.07%   -0.01%     
==========================================
  Files         793      794       +1     
  Lines       51226    51246      +20     
==========================================
+ Hits        31288    31296       +8     
- Misses      17062    17073      +11     
- Partials     2876     2877       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.