Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core feature] add more intuitive methods to FlyteRemote class for gate nodes #3459

Open
2 tasks done
cosmicBboy opened this issue Mar 13, 2023 · 2 comments · May be fixed by flyteorg/flytekit#2933
Open
2 tasks done

[Core feature] add more intuitive methods to FlyteRemote class for gate nodes #3459

cosmicBboy opened this issue Mar 13, 2023 · 2 comments · May be fixed by flyteorg/flytekit#2933
Assignees
@mao3267
Labels
enhancement New feature or request flytekit FlyteKit Python related issue flyteremote good first issue Good for newcomers UX Issues that require UX-Design
Milestone
2023 Backlog

Comments

@cosmicBboy
Copy link
Contributor

Motivation: Why do you think this is important?

The purpose of this issue is to make it more intuitive to use FlyteRemote for providing input values for wait_for_input and approve gate nodes.

Goal: What should the final outcome look like, ideally?

Proposal

Add three new methods:

  • FlyteRemote.approve(<signal_id>, <execution_name>, project=None, domain=None): sets this approve gate node to True
  • FlyteRemote.reject(<signal_id>, <execution_name>, project=None, domain=None): sets this approve gate node to False
  • FlyteRemote.set_input(<signal_id>, <execution_name>, <value>, project=None, domain=None, python_type=None, literal_type=None): sets the input of a wait_for_input gate node to <value>

Describe alternatives you've considered

Continue with the currently FlyteRemote.set_signal implementation.

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@cosmicBboy cosmicBboy added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Mar 13, 2023
@cosmicBboy cosmicBboy added this to the 2023 Q1 Backlog milestone Mar 13, 2023
@pingsutw pingsutw added good first issue Good for newcomers flytekit FlyteKit Python related issue UX Issues that require UX-Design flyteremote and removed untriaged This issues has not yet been looked at by the Maintainers labels Dec 22, 2023
@Future-Outlier
Copy link
Member

docs: https://docs.flyte.org/en/latest/user_guide/advanced_composition/waiting_for_external_inputs.html#waiting-for-external-inputs

@mao3267
Copy link
Contributor

mao3267 commented Nov 11, 2024

#take

@Future-Outlier Future-Outlier linked a pull request Nov 15, 2024 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mao3267 mao3267

Labels
enhancement New feature or request flytekit FlyteKit Python related issue flyteremote good first issue Good for newcomers UX Issues that require UX-Design
Projects
None yet
Milestone
2023 Backlog
Development

Successfully merging a pull request may close this issue.

[WIP] Separate remote signal functions mao3267/flytekit
4 participants
@cosmicBboy @pingsutw @mao3267 @Future-Outlier