Add GetSpanPath and SpanExists #361
Conversation
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
| return r.SpanPath != nil, nil | ||
| } | ||
|
|
||
| func NewInMemoryOutputReader(literals *core.LiteralMap, DeckPath *storage.DataReference, SpanPath *storage.DataReference, err *io.ExecutionError) InMemoryOutputReader { |
There was a problem hiding this comment.
Could we add a new function called NewInMemoryOutputReaderWithSpan? Spotify is using this function internally, so we can't change it. #268 (comment)
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 62.62% 64.00% +1.38%
==========================================
Files 152 152
Lines 12789 10388 -2401
==========================================
- Hits 8009 6649 -1360
+ Misses 4168 3126 -1042
- Partials 612 613 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
|
Hi, we are moving all Flyte development to a monorepo. In order to help the transition period, we're moving open PRs to monorepo automatically and your PR was moved to flyteorg/flyte#4128. Notice that if there are any conflicts in the resulting PR they most likely happen due to the change in the import path of the flyte components. |
TL;DR
This is part of Flytekit Metrics Exploration.
This PR helps propeller to get span uri(highlighted in green).
Flytekit Metrics Exploration includes:
flytekit: Upload Flytekit runtime metrics to S3 flytekit#1683
flyteplugins: Add GetSpanPath and SpanExists #361
flyteidl: Add span uri flyteidl#415
flytepropeller: Add span uri to node event flytepropeller#577
flyteadmin: Implement GetFlyteKitMetrics endpoint flyteadmin#575