From 6a15988a88424025d971ef8bc07260b76c6c8366 Mon Sep 17 00:00:00 2001 From: Kevin Su Date: Tue, 11 Jun 2024 14:03:00 +0800 Subject: [PATCH] Remove mmcloud plugin example (#1696) Signed-off-by: Kevin Su --- docs/conf.py | 3 -- docs/index.md | 1 - examples/mmcloud_plugin/Dockerfile | 27 ---------------- examples/mmcloud_plugin/README.md | 3 -- .../mmcloud_plugin/mmcloud_plugin/__init__.py | 0 .../mmcloud_plugin/mmcloud_plugin_example.py | 32 ------------------- examples/mmcloud_plugin/requirements.in | 1 - examples/ray_plugin/ray_plugin/ray_example.py | 2 +- 8 files changed, 1 insertion(+), 68 deletions(-) delete mode 100644 examples/mmcloud_plugin/Dockerfile delete mode 100644 examples/mmcloud_plugin/README.md delete mode 100644 examples/mmcloud_plugin/mmcloud_plugin/__init__.py delete mode 100644 examples/mmcloud_plugin/mmcloud_plugin/mmcloud_plugin_example.py delete mode 100644 examples/mmcloud_plugin/requirements.in diff --git a/docs/conf.py b/docs/conf.py index f98981a7a..d8ce10fca 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -185,7 +185,6 @@ "testing", "bigquery_plugin", "databricks_plugin", - "mmcloud_plugin", "snowflake_plugin", ] @@ -332,8 +331,6 @@ "auto_examples/kftensorflow_plugin/index.html": "https://docs.flyte.org/en/latest/flytesnacks/examples/kftensorflow_plugin/index.html", "auto_examples/mlflow_plugin/index.html": "https://docs.flyte.org/en/latest/flytesnacks/examples/mlflow_plugin/index.html", "auto_examples/mlflow_plugin/mlflow_example.html": "https://docs.flyte.org/en/latest/flytesnacks/examples/mlflow_plugin/mlflow_example.html", - "auto_examples/mmcloud_plugin/example.html": "https://docs.flyte.org/en/latest/flytesnacks/examples/mmcloud_integration/example.html", - "auto_examples/mmcloud_plugin/index.html": "https://docs.flyte.org/en/latest/flytesnacks/examples/mmcloud_integration/index.html", "auto_examples/mnist_classifier/pytorch_single_node_and_gpu.html": "https://docs.flyte.org/en/latest/flytesnacks/examples/mnist_classifier/pytorch_single_node_and_gpu.html", "auto_examples/mnist_classifier/index.html": "https://docs.flyte.org/en/latest/flytesnacks/examples/mnist_classifier/index.html", "auto_examples/mnist_classifier/pytorch_single_node_multi_gpu.html": "https://docs.flyte.org/en/latest/flytesnacks/examples/mnist_classifier/pytorch_single_node_multi_gpu.html", diff --git a/docs/index.md b/docs/index.md index ede9ca35b..5cf0650ea 100644 --- a/docs/index.md +++ b/docs/index.md @@ -142,7 +142,6 @@ auto_examples/whylogs_plugin/index Deprecated integrations BigQuery plugin Databricks plugin -MMCloud plugin Snowflake plugin ``` diff --git a/examples/mmcloud_plugin/Dockerfile b/examples/mmcloud_plugin/Dockerfile deleted file mode 100644 index 4e04f77bd..000000000 --- a/examples/mmcloud_plugin/Dockerfile +++ /dev/null @@ -1,27 +0,0 @@ -FROM python:3.11-slim-bookworm -LABEL org.opencontainers.image.source https://github.com/flyteorg/flytesnacks - -WORKDIR /root -ENV VENV /opt/venv -ENV LANG C.UTF-8 -ENV LC_ALL C.UTF-8 -ENV PYTHONPATH /root - -WORKDIR /root - -ENV VENV /opt/venv -# Virtual environment -RUN python3 -m venv ${VENV} -ENV PATH="${VENV}/bin:$PATH" - -# Install Python dependencies -COPY requirements.in /root -RUN pip install -r /root/requirements.in - -# Copy the actual code -COPY . /root - -# This tag is supplied by the build script and will be used to determine the version -# when registering tasks, workflows, and launch plans -ARG tag -ENV FLYTE_INTERNAL_IMAGE $tag diff --git a/examples/mmcloud_plugin/README.md b/examples/mmcloud_plugin/README.md deleted file mode 100644 index 2b13cf3bd..000000000 --- a/examples/mmcloud_plugin/README.md +++ /dev/null @@ -1,3 +0,0 @@ -**Note:** This example code uses a legacy implementation of the MemVerge Memory Machine Cloud (MMCloud) integration. We recommend using the [MMCloud agent](https://docs.flyte.org/en/latest/flytesnacks/examples/mmcloud_agent/index.html) instead. - -This directory contains example code for the deprecated MMCloud plugin. For documentation on installing and using the plugin, see the [MMCloud plugin documentation](https://docs.flyte.org/en/latest/deprecated_integrations/mmcloud_plugin/index.html) diff --git a/examples/mmcloud_plugin/mmcloud_plugin/__init__.py b/examples/mmcloud_plugin/mmcloud_plugin/__init__.py deleted file mode 100644 index e69de29bb..000000000 diff --git a/examples/mmcloud_plugin/mmcloud_plugin/mmcloud_plugin_example.py b/examples/mmcloud_plugin/mmcloud_plugin/mmcloud_plugin_example.py deleted file mode 100644 index a4ed4664f..000000000 --- a/examples/mmcloud_plugin/mmcloud_plugin/mmcloud_plugin_example.py +++ /dev/null @@ -1,32 +0,0 @@ -from flytekit import Resources, task, workflow -from flytekitplugins.mmcloud import MMCloudConfig - - -# `MMCloudConfig` configures `MMCloudTask`. -# Tasks specified with `MMCloudConfig` will be executed using MMCloud. -# Tasks will be executed with requests `cpu="1"` and `mem="1Gi"` by default. -@task(task_config=MMCloudConfig()) -def to_str(i: int) -> str: - return str(i) - - -@task(task_config=MMCloudConfig()) -def to_int(s: str) -> int: - return int(s) - - -@task( - task_config=MMCloudConfig(submit_extra="--migratePolicy [enable=true]"), - requests=Resources(cpu="1", mem="1Gi"), - limits=Resources(cpu="2", mem="4Gi"), - environment={"KEY": "value"}, -) -def concatenate_str(s1: str, s2: str) -> str: - return s1 + s2 - - -@workflow -def concatenate_int_wf(i1: int, i2: int) -> int: - i1_str = to_str(i=i1) - i2_str = to_str(i=i2) - return to_int(s=concatenate_str(s1=i1_str, s2=i2_str)) diff --git a/examples/mmcloud_plugin/requirements.in b/examples/mmcloud_plugin/requirements.in deleted file mode 100644 index 17c327692..000000000 --- a/examples/mmcloud_plugin/requirements.in +++ /dev/null @@ -1 +0,0 @@ -flytekitplugins-mmcloud diff --git a/examples/ray_plugin/ray_plugin/ray_example.py b/examples/ray_plugin/ray_plugin/ray_example.py index 347a0f61e..159f9a27c 100644 --- a/examples/ray_plugin/ray_plugin/ray_example.py +++ b/examples/ray_plugin/ray_plugin/ray_example.py @@ -22,7 +22,7 @@ custom_image = ImageSpec( registry="ghcr.io/flyteorg", packages=["flytekitplugins-ray"], - # kuberay operator needs wget for readiness probe + # kuberay operator needs wget for readiness probe. apt_packages=["wget"], )