Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sparse fields and includes do not play well when applied together #156

Open
EugeneKostrikov opened this issue Aug 17, 2015 · 2 comments
Open

Sparse fields and includes do not play well when applied together #156

EugeneKostrikov opened this issue Aug 17, 2015 · 2 comments
Labels
Medium Complex

Comments

@EugeneKostrikov
Copy link

Given all references are set up correctly:
GET '/people/:id?include=pets&fields=name,pets' will apply ?fields to both "people" and "pets" resources
GET '/people/:id?include=pets&fields=name' will not include "pets" at all

There might be other edge cases that need some treatment as well
@EugeneKostrikov
Copy link
Author

The tests here illustrate the problem #157

@chiragdoctor
Copy link

Please find the PR for this issue #174 here for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Medium Complex
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EugeneKostrikov @chiragdoctor