Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create graph visualizations with nn.Parallel #6

Open
fmassa opened this issue Mar 28, 2016 · 0 comments · May be fixed by #10
Open

Can't create graph visualizations with nn.Parallel #6

fmassa opened this issue Mar 28, 2016 · 0 comments · May be fixed by #10

Comments

@fmassa
Copy link
Owner

fmassa commented Mar 28, 2016

The current way of generating the graph in graphgen.lua is to rely on the input and self.output of each module. The underlying assumption is that those tensors will be the same for every forward call (i.e., no new tensor is created for both the input and the output, but they are instead reused).

This is not the case for nn.Parallel, as a new tensor is created at every forward pass. The same applies for nn.ParallelTable when the input is a tensor, or modules that allocate a new self.output tensor at every forward pass.

I will try to figure out a way of making the graph generation more robust, without having to define special cases for every module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant