Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphgen improvements #10

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Graphgen improvements #10

wants to merge 7 commits into from

Conversation

fmassa
Copy link
Owner

@fmassa fmassa commented Apr 12, 2016

Should fix #6
There is a lot of magic going on in here:

  • temporarily overwrite torch __index and select to keep track of the modules in which those functions were called (thanks upvalues !)
  • if the input tensors are not found in nodes table, look for them in the trickyNodes table, which contains the tensors created via __index and select during the forward call
  • additionally, remove the need of having to run forward before generating the graph to pre-allocate self.output, by adding the output edges after each module's call.

cc @szagoruyko

fmassa added a commit that referenced this pull request Apr 27, 2016
Fix is included in PR #10, but I fix it here for #11
@fmassa fmassa mentioned this pull request Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create graph visualizations with nn.Parallel
1 participant