Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Test Revamp - Efficient Frontier and Monte Carlo #121

Open
wasimnoordin opened this issue Jul 31, 2023 · 1 comment
Open

Unit Test Revamp - Efficient Frontier and Monte Carlo #121

wasimnoordin opened this issue Jul 31, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@wasimnoordin
Copy link

Hi @fmilthaler / @PietropaoloFrisoni,

When you guys get the time, could you add some unit tests for the monte_carlo and efficient_frontier modules? I feel that these are as essential as the portfolio file. Understanding the effect of changes to preserving the functionality could be made clearer through a few more comprehensive unit tests.

Thanks for your continued hard work.

@fmilthaler
Copy link
Owner

Hey @wasimnoordin , fully agree with you, those modules should get proper tests. Currently the monte carlo and efficient frontier code is tested implicitly through the Portfolio and examples. Obviously that is not great, and proper tests should be implemented for both. Thanks for opening this issue. We'll see when that'll happen, for now there are some other things we are focussing on, but I'll keep this in mind.

@fmilthaler fmilthaler added the enhancement New feature or request label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants