Skip to content

Commit

Permalink
[TASK] Add some comments and ignore extension scanner false positive
Browse files Browse the repository at this point in the history
  • Loading branch information
fnagel committed Mar 26, 2024
1 parent 3cfe6e8 commit e1ddb4d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions Classes/Controller/AbstractController.php
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ protected function clearPageCache()
FlushCacheService::clearPageCache();
}

// @todo Does this need to be reworked for TYPO3 v13?
protected function pageNotFoundAndExit(string $message = 'Entity not found.')
{
$response = GeneralUtility::makeInstance(ErrorController::class)->pageNotFoundAction(
Expand Down
1 change: 1 addition & 0 deletions Classes/Controller/PostController.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public function __construct(protected PostRepository $postRepository)
protected function handleKnownExceptionsElseThrowAgain(\Throwable $exception)
{
if ($exception instanceof TargetNotFoundException) {
// @extensionScannerIgnoreLine
$this->pageNotFoundAndExit();
}

Expand Down
2 changes: 2 additions & 0 deletions Classes/Service/SpamCheckServiceInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ interface SpamCheckServiceInterface
/**
* Checks GET / POST parameter for SPAM.
*
* @todo Add request argument!
*
* @return int SPAM points
*/
public function process(array $settings): int;
Expand Down

0 comments on commit e1ddb4d

Please sign in to comment.