Support both older and newer versions of Netcat #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we don't really know the OS and the version of nc, make an educated guess by grepping the output of its help text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. On Ubuntu 16.04,
ncdoesn't have a-Nparameter. But on 20.04, it seem to have it. Both land in the sameifof the daemon-wrapper script.This PR does a grep in the output of
nc -hto check if there is a parameter named-Nor not, and use the command based on it.This could possibly replace the whole list of ifs, but that's not something I can verify. I just know that in the case where we don't really know what the OS is, making an educated guess seems like a better idea than just forcing one of the two choice.
Regards, and thanks for this project!