From 2d8da6c5ab51d56b987c9182466e8e6eef6dca06 Mon Sep 17 00:00:00 2001 From: Jerry Lee Date: Sat, 23 Nov 2024 19:48:10 +0800 Subject: [PATCH] =?UTF-8?q?feat:=20change=20default=20value=20of=20`cffu.u?= =?UTF-8?q?ncaught.exception.report`=20to=20`full`;=20fail=20LOUDLY=20?= =?UTF-8?q?=F0=9F=92=A3?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../main/java/io/foldright/cffu/ExceptionReporter.java | 2 +- scripts/integration_test | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/cffu-core/src/main/java/io/foldright/cffu/ExceptionReporter.java b/cffu-core/src/main/java/io/foldright/cffu/ExceptionReporter.java index 8ba2e12c..ebc55449 100644 --- a/cffu-core/src/main/java/io/foldright/cffu/ExceptionReporter.java +++ b/cffu-core/src/main/java/io/foldright/cffu/ExceptionReporter.java @@ -25,7 +25,7 @@ static T reportUncaughtException(String where, Throwable ex) { final String shortReport = "short"; final String noneReport = "none"; - final String report = System.getProperty("cffu.uncaught.exception.report", shortReport); + final String report = System.getProperty("cffu.uncaught.exception.report", fullReport); final String msgHead = "Uncaught exception occurred at "; if (noneReport.equalsIgnoreCase(report)) { // pass silently when explicitly silenced. diff --git a/scripts/integration_test b/scripts/integration_test index 6c09cea3..797cbd03 100755 --- a/scripts/integration_test +++ b/scripts/integration_test @@ -65,16 +65,18 @@ mvu::mvn_cmd clean install readonly MVN_OPTS_FOR_JAVA8=( -Dkotlin.version=1.6.0 -Dguava.version=29.0-jre -P!default-logging-dependencies -P!default-arch-unit-test + -Dcffu.uncaught.exception.report=short ) # shellcheck disable=SC2034 readonly MVN_OPTS_FOR_JAVA11=( -Dkotlin.version=1.7.0 -DswitchToLog4j2LoggingDependencies -Pswitch-slf4j-to-v1 + -Dcffu.uncaught.exception.report=short ) # shellcheck disable=SC2034 readonly MVN_OPTS_FOR_JAVA17=( -Dkotlin.version=1.8.0 - -DswitchToLog4j2LoggingDependencies -Dcffu.uncaught.exception.report=full + -DswitchToLog4j2LoggingDependencies -Dcffu.uncaught.exception.report=short ) # shellcheck disable=SC2034 readonly MVN_OPTS_FOR_JAVA23=( @@ -94,8 +96,8 @@ for jdk_version in "${JDK_VERSIONS[@]}"; do jvu::switch_to_jdk "$jdk_version" - # skip kotlin module test for low java version(19-) - # need recompile and test later(more info see the comments) + # skip kotlin module test for low java version(18-) + # need recompile and test later(more info see its comments) pl=() if ((jdk_version < default_build_jdk_version && jdk_version < 19)); then pl=(-pl 'cffu-core,cffu-ttl-executor-wrapper')